Post by grywec in Lust Harem (NSFW) 18+ comments

Viewing post in Lust Harem (NSFW) 18+ comments

in 0.20 an exception is thrown in battle when the last kill in the combat before was done by a minion. it's not a hard crash but can be mitigated with "ignore" twice

[..]
  File "game/myscripts/battle engine/battle/battle.rpy", line 284, in <module>     
    text "What will {0} do?".format(currentplayer.name) outlines[ (absolute(10), "#000", absolute(2), absolute(2)) ] 
AttributeError: 'NoneType' object has no attribute 'name'</module>

not exactly sure about the root cause, maybe the battle end does not (re)set the variables/classes correctly when the final kill was not done by MC or Asara

if you need it I can post the whole trace or prepare a save game

Xiongmao3 years ago (1 edit)

It's the text under combatlog. For some reason it didn't reset for you. Did you use 'all minions attack'?

EDIT:

Found the issue. Happens when you skip (left CTRL) when selecting 'All minions attack'. For some bizzare reason it also skips the variable change.

This will be fixed in the next update/hotfix. Thank you for the report.

grywec3 years ago

quite sure I was not skipping but an unset variable seems very plausible.

will report if it works for me in the next release :)

grywec3 years ago (1 edit)

and one QoL change request: please add tooltips with the name to the Characters screen similar to the ones in Skills.

use case: my memory for names sucks :) exploring the new features I bought the outfit for some Isabelle and it took me a lot of clicking around in the chars' screen to identify her :D

PS another totally critical bug deserving a hot fix: titus exposus does not work on the woman in dungeon lvl 4 :P

Xiongmao3 years ago (1 edit)

I'll add that. Shouldn't be a problem.

As for errors with minions. I've noticed it giving the same error in a few other cases, when canceling skill selection and so on. Think I eliminated them all now.

Thank you again.

Edit: Heh. Didn't think of that as she's a spirit and wouldn't care. Main issue now would be the scenes that follow after (she's fully dressed in them from what I remember). I'll look into changing that but that's something to be done in the future.

grywec3 years ago

great, thanks for checking & fixing!

and I didn't meant the spell as way to end the fight but as eye candy gimmick. but yes, you'll would have to create a new set of windows for the scene after the combat, probably not worth your time for a small easter egg

Ghryst3 years ago

if you made the spell effect just pull her shirt down, you could just add a second shot where she pulls her clothes back up, and no need to re-cast all the following shots in the ending scene

Xiongmao3 years ago(+1)

Not a bad idea. I'll probably do that or something similar.
I haven't looked at that event for a while now.

grywec3 years ago

somehow HP regen is not working.

the regen part of invEquip() in char_def is triggered when equipping the troll ring, but startPlayersTurn() in battle_def gives 0 for MC's p.regen['hp']

Xiongmao3 years ago

Just checked. Works fine. Are u sure about this one? Check if your regen drops to -1 if u unequip the ring.

grywec3 years ago

can I somewhere see the regen value? the only way I'm aware of is to take an eye between combat rounds

Xiongmao3 years ago

No, I'll throw it in. Shouldn't be difficult to see though. Just keep 1 rat alive and check if you lost HP or not.

grywec3 years ago

I added HP and MP regen to "screen inventory_screen()" in inventory.rpy, generally quite useful, imo

text "MP regen: [h.regen[mp]]" style "inventory_stats"
text "HP regen: [h.regen[hp]]" style "inventory_stats"

and you're right, the base value for HP is -1. my MC is suicidal, too much talking with Klaus, I presume :D

Xiongmao3 years ago

I'm still pondering how you managed to lower your regen to -1. Any chance you used the console after equipping the ring?

grywec3 years ago

don't think too much about my fucked up save game - I like to fool around in renpy scripts (e.g when your dungeon only had two levels Asari had the talk option "Reset Dungeon") and while I never knowingly changed char settings it is totally possible that I caused the slow dying myself.

but while trying to reproduce it I found a new bug: On afternoons Asari is in her dorm room but can still be selected from the lib entrance.

00_library, in screen library_entrance_click()

if clock.time == "noon" or clock.time == "afternoon":
    imagebutton auto "locations/library/asara_noon_ent_%s.png" focus_mask True action Jump ("asara_noon_talk")

imo the 'or clock.time == "afternoon"' should be replaced with '( or clock.time == "afternoon" and asa.story <=5 )', so the entrance is identical to the side view in 'screen library_side1_click()'

Xiongmao3 years ago

I'll look into it. Thank you!

View more in thread

grywec3 years ago

and the cure poison is working only with delay?

- got poisoned (w/ poison damage)

- drank anti poison potion (health bar not green again, condition icon gone)

- got poison damage (wait, what?)

noticed this with the Manticore and did not test it further

Xiongmao3 years ago(+1)

That is idd a bug. I'll get it fixed.

grywec3 years ago (1 edit)

aaaand one more, but I saw all the new content, should be the final one :)

replaying The Bitcher on the laptop has a lot of image not found errors.

compare the working scene in 02_varess

scene laptop2_13 with dissolve 
    triss "Geralt."
[..]

with the b0rken one in my_computer

scene varess5a_13 with sfade
    triss "Geralt."
[..]

replacing 'varess5_' with 'laptop2_' in my_computer seems to solve this

edited to add: there is no way to unlock the love wallpaper? persistent.lovewallpaper is never set to true

Xiongmao3 years ago

My bad. I changed the scene names. Thanks for the reports.

Love wallpaper - not at the moment, no. I'll throw it with some other content or for Valentine's

itch.io

Viewing post in Lust Harem (NSFW) 18+ comments