Something odd happening with the impregnation function - on clicking next day button:
SCRIPT ERROR: impregnation: Invalid get index 'id' (on base: 'Nil').
At: res://files/globals.gd:1132
Hmm, I think I know what that is from, I had looked it up when someone posted the same error in another thread. Theirs was at 1131, but I imagine that just means you have an extra line of code somewhere before that in your version of globals.gd. The error in question is most likely a result of the impregnation function not being passed a "father" person, like would happen during most of the sex jobs, or randomly to someone being a housepet or sleeping in the kennel. The random events that involve sex with a random "male" character that isn't you or a slave will also pass no father to that function.
Original impregnation would create a random generic person to be the father in those cases but the edits to how breeding slaves works broke that functionality. I have made a bunch of changes to that function and the ones that use the outputs from it myself, but haven't gotten around to testing them yet, if they work when I do test them I will post them.
Hmm not quite as bad as I thought...
Only minor changes to constructor.gd, basically I moved the <type>_race_arrays out of the set genealogy function so that I could look at them in globals, rather than rebuilding the arrays myself. (edit: I am also using the arrays in multiple functions within constructor itself, but that is for an entirely different unfinished thing)
I added entries to races.gd for each of the animal types, a little bit of work to prevent characters generating with an animal race but not that hard, most character generation is either already filtered or used globals.allracesarray when generating characters, so I just had to prevent the animal races from being populated into that array.
For globals.gd I did the aforementioned filtering to keep animal races out of allracesarray
had to make major changes to the impregnation, race_breed_compatible, and fertilize_egg functions,
as well as adding another array for race groups to be used with the getracebygroup function, including adding addition group filters to said function
And lastly in every file that calls globals.impregnation without providing a father person, I had to add a new input to target either a specific race or group of races to generate a father from.
Aric if I can get my internet to cooperate I will try to send the changes on discord, if you need them. It would be quite the wall of text to post it here.
Please read this thread for similarities and the likely cause: https://itch.io/t/702443/bug-single-color-portraits
Your computer may be different and their solution may not work for you.
How is testing going?
Waiting for update, as v0.9.5 is bit unplayable for my playstyle,
due most of the bugs mentioned in these posts on v0.9.5.
And your mod just adds to much good content to ignore.
For future:
I recently realized it is similar mechanic on cross-breeding compared to Strive 2 alpha game.
So having like a breeder trait from Strive 2 alpha would be awesome.
And you could apply also that partially to current MC breeders trait also.
I'm not exactly a fan of this suggestion, as this still feels like a pretty hefty nerf to the Breeder play through. Seems kind of unfair that a specific PC play through would have to jump through so many hoops just to actually be, y'know, a Breeder. Some other way to spend mana might be nice, especially at endgame, but this suggestion isn't a proper solution. Right now, I've essentially quit playing the game until 0.9.6 releases, as the Breeder is the only play though I haven't done yet. I was waiting on Farms to be fully implemented before giving Breeder a go, and then I delayed even more when I heard that 0.9.5 would have a whole bunch of reworked impregnation/races/interactions and stuff. But then the new changes also inadvertently nerfed Breeder almost into the ground, so now I'm just chilling till 0.9.6.
Generally, this error means that you have installed the Random Portrait mod more than once at the same time, so the duplicate code causes errors. This can happen if Aric's mod is re-installed without removing all the other mods, as the act of deleting the backup folder causes those mods to become part of the default scripts. The simple fix would be to un-apply the Random Portrait mod to see if it remains installed and play like that. Otherwise you will need to start a fresh Strive program folder and reinstall your mods.
It appears that you have not completed the installation of the mod.
"Passive" is the name of a function in the 'abilities.gd' file, which corresponds to a type of effect applied to combatants. Specifically it results from using the "Armor Breaker" weapon, as that weapon has incorrect data and code, causing it to generate errors and backfire against the person holding the weapon.
I believe that Slimes were changed so that they no longer get pregnant in the same way as other characters, as stated on the first page:
Currently, the only restriction on breeding is Slimes. Slimes can't currently breed or be bred by other races (there's some new functionality coming for them soon to match their lore and give a different breeding option).
It appears that there are some typos in that line of code. On line 1173 of globals.gd, it should probably be:
mother.preg.womb.append({id = father_id, unique = father_unique, semen = cumprod, virility = virility, day = 0,})since this would use the substitute variables instead of trying to use indexes of the "father" argument. There could be other problems because I haven't tested it, just skimmed through the local code.
There are 2 problems here: the simple irrelevant one that causes the error message, and the more complex issues of string inequality and genetic sums.
Each of the lines like "father.dog" is missing ".genealogy", which is where the animal indexes are found. So "father.dog" should be "father.genealogy.dog". This also needs to be fixed for "bunny", "cow", "cat", "fox", "horse", and "raccoon".
However, just a couple lines later "set_genealogy" is called, which will attempt to re-assigns these same values. At least it would except that the virtual father has his race assigned to "dog", which does not decode to any expected race(the code looks for "Wolf"). So it should blow up at line 513 of constructor.gd. We can prevent this by adding "father.race = " followed by the string found in the "genealogy_decoder" function of constructor.gd that corresponds to each of the animals we fixed above, though it's a rough fix.
This brings us to the next issue, relatively minor, the "fertilize_egg" function in globals.gd is setting a single race's genetics to 100, but it never clears the rest of the percentages that are created for the virtual father. "set_genealogy" also never clears these extra percentages, and while it should equalize to 100 at the end there will likely be some percentage that remains a random race. To fix this, we would need to zero all percentages in the genealogy similar to "var genealogy" in person.gd instead of assigning 100 for each animal, which means deleting the lines that would have been fixed at the top. So copying "var genealogy" into the start of the "fertilize_egg" function and replacing each 100 assignment with "father.genealogy = genealogy" should fix this, again it's a rough fix.
The child did not qualify for any existing race, so it defaulted to Human. Generally, they need at least 50% a single race or at least 30% of some of the animal types for Halfkin. Edit: corrected conditions
Like Ank pointed out, the racial picker defaults to Human if there isn't a 50+ or 30+ for Halfkin races for the "actual" race. The bonuses are all given via the genetics themselves, but the game has to still have an assigned race for general compatibility. It wasn't the most immersive way of handling it, but it got it functional. I have a new calculation I'm bug-testing that will always try to pick the highest, rarest genetics and give that as the "assigned" race.
Finally managed to solve whatever issue was stopping me from playing with this mod installed - still don't know what the issue was mind you, just reinstalling 100 times did work in end.
Seem to be having an odd issue with the pregnancy system though. As I noticed in above post there's a known issue with genetics showing up over 100%, which I don't really mind since it doesn't affect gameplay, but the genetics of my child seem to be making a mess of it's race. My MC is a pure demon, and girl he's getting pregnant is 74/26 demon/harpy. I've tried having multiple children with her but they keep being harpy. Whilst that's not impossible given female's harpy genetics, the genetic makeup is showing as 91 demon/55 harpy. Doesn't really make any sense even ignoring the over 100%. If she's higher demon than harpy, shouldn't she be a demon? And how exactly does a combination of parents that's basically 87% demon and 13% harpy get a child 55 harpy? Overall, I get the feeling something in the genetics system isn't working properly.
And as a side note on same system, I noticed that sometimes 'impure' characters are being labelled 'pure <race>' and vice versa.
And just whilst noting things, also having an issue where group sex scenes keep having mentions about 'undersized' shafts even when they aren't. Especially doesn't make sense when it says 'undersized decently-sized manhood' :)
Images for above issues below.
Your child was likely given Harpy as a race since it is later on the list of races checked for 50+ genetics. The latter race checked for is always the one chosen, and the order appears arbitrary. This issue would exist with a 50-50 child, so 100+ genetics is not relevant.
There was an issue with the code to change 100+ genetics to 100 in v0.9.5, so if you got someone pregnant in that version then it would persist even in v0.9.6. If not, then I'm not sure of the cause of the 100+ genetics, since I've read the related code multiple times and not seen anything wrong.
I figured it out, all the slaves have 100 genetic sums, but the description only shows the positive genetics so the total appears higher. There are 2 sources of the problem.
The first is "set_genealogy" in constructor.gd does not reset the existing genealogy of a person before adding in the new. This is specifically an issue for impregnation from virtual fathers(prostitution or kennel). This is bugged and unless you fix line 1173 in globals.gd it will never happen. When fixed, "set_genealogy" is used to assign custom genetics to the virtual father, thus always ending up with 200 genetics.
The second cause is that "build_genealogy_equalize" has a small defect as it assumes that for 100+ genetics so long as the current genetic line is positive that you can subtract any amount from it. However, that can only be true for purebreeds, otherwise you can end up with negative genetic lines. Thus 100 is always reached, but it in an unbalanced way. The fix for this is simple, "random_number" needs to limited to at most the current value of the genetic line. A similar fix could be made for the 100- genetics, though once the above problem is fixed this function should almost never be used and it is of questionable value to begin with.
Working on testing the fix for the racial issues Darkness, but group sex issues have and continue to be a PITA. That's a future project. It's basically combining the sex partners and trying to parse the text for each of them based on 1 calc I think.
