MV - Dual Wield

I get an error on an dual wielding char only if she uses a sword and a shield and performs a skill. When she uses two weapons, the error does not occur. I think it has something to do with checking the weapon type of the offhand, but since it´s a shield, it throws the error. I hope I explained it enough^^

I just noticed another thing. When a two-handed character only wields a weapon in his main hand, he will attack twice, even if barehanded attack is turned off.

Ramza1 year ago

Hey there.

This appears to be an issue with a change I implemented a while back. Originally I had modified the actor.isDualWield() function to return false in battle if the actor was dual wield type, but wasn't currently wielding two weapons. A couple of updates ago, I undid this change, and replaced most of those checks with a new function actor.isCurrentlyDualWielding(), the purpose of this change was so that in battle equipment changing plugins didn't incorrectly determine that an actor couldn't wield an offhand weapon.

It appears after I made this change, the function causing your crash was not updated. With the original change to the dual wield function, it would not have checked the wtype of the offhand item if the actor was barehanded or using a shield, but now it does both.

I have uploaded a fix for this, in the newest version. The second issue you posted about below is also because of the same thing, the function that determines if an actor is dual wielding, and adds the second attack action was also checking if they were dual wield type, and not if they were currently dual wielding.

~Ramza

Rakon1 year ago (1 edit)

Thank you for your quick update!^^

Unfortunately the second issue is still present and the character double attacks when he wields only one weapon and nothing in the other hand.

I just found out that now a two handed char will always attack twice, when he does NOT wield a shield. Unfortunately even if barehanded attacks are turned off.

Ramza1 year ago

I'm looking into this further, but the test project has no such issue. When equipped with only one two handed weapon, there is no extra attack, with or without the barehanded attack option enabled.

Are you also using the monkeygrip extension? The extension might be overwriting some of the changes I just made. Also, if the actor we're talking about has monkeygripping enabled, the two handed weapon in the main hand would be considered a one handed weapon, meaning he should be able to get a barehanded attack as an offhand attack, at least if that parameter was enabled.

~Ramza

No monkeygrip plugin. All of your plugins are close of the bottom of the list.

*note: I haven´t used the bock chance plugin, thats the reason its disabled.^^

CtelinAjira1 year ago

Using MV. I've checked the loading order, and it...seems correct to me.

Still, I ran into the following bug on boot. After making sure the weapons weren't equipped until runtime, I met the bug again upon trying to access the equipment screen.

CtelinAjira1 year ago (1 edit)

UPDATE: Managed to solve this by changing the 'includes' calls in isMHAllowedWithOffHandWtypeId and isOHAllowedWithMainHandWtypeId to 'contains' calls.

Ramza1 year ago (2 edits) (+1)

While I'm glad you solved that issue, something about it doesn't add up here.

That function should be given an array from the item with a list of the unequippable wtypeIds in it. array.contains() isn't a function, which I why I used array.includes() instead. It would appear, however, that the item is not getting an array of disallowed wtypeIds, but is instead only getting a string, as string.contains() is a function that exists.

It appears the bug is caused because your item only has one disallowed wtypeId, so it was saved on the item as a string instead of an array. That means when you make an item that has more than one disallowed item with your changes, it will crash the game in the same way as it did before when using includes.

I will correct the way the notetag is being parsed, and upload an updated version shortly.

~Ramza

edit:
I can't find any fault with the note tag in the way it reads the tags to set the disallowed wtypes array. If you don't include the leading space before listing the numbers, it doesn't trigger the notetag at all, and if you include a space after the first number, it pushes a value of 0 to the disallowed weapon types array. Neither of these cause the crash. In the first case, the array would remain blank, as every weapon gets a blank array on database load, and in the second, it would simply disallow equipping whatever item this was with a barehand in the other hand.

I'm not sure why it's not saving the value correctly on your project, but the edit you made will certainly cause the same crash again if any weapon has more than one disallowed wtypeId on it.

CtelinAjira1 year ago (1 edit)

Interesting. I see that rpg_core.js has defined it as an additional property of arrays:

Ramza1 year ago(+1)

Alright, well, maybe it'll continue to work then.

I'm still not sure why includes didn't work though. Since it is a default property of arrays, and that is what should be on the items, and more importantly, why it works fine in my test project, and at least one other project out in the wild.

But if this modification works for you, I guess we can leave it at that, lol.

Timerox2 years ago

I'm new to the rpg mv making business and I was looking for a plug in play plugin that would allow me to bring duel wielding to my game (and balance it out), but I am met with-

Not too sure of what the issue is exactly or how to fix it. I have the core plugin in as well as the duel wield one under it. The demo map doesn't work either. Some clarification on this would be great!

Timerox2 years ago

I figured it out, I in fact did not download the correct battle core plugin. Ignore my previous comment!

Timerox2 years ago

Hold on, there was that issue when I used the newest version of your plugin, but when I used the older version from the demo, it works fine. Weird

Hey there.

The unshift crash happens if you're not using BattleCore. In the very early versions of the plugin, including the one in the demo folder, the BattleCore wasn't technically required, although the plugin still visually looked a lot better when BattleCore was used. In an early update, one of the changes I made to the plugin to make it more plug and play friendly adds a bunch of action sequence commands to the attack skill (and other dual wield skills) which reset some counters and perform some extra clean up after a dual wield attack.

For the most part, this is invisible to the end user, but if you're not using BattleCore, it causes this error.

~Ramza

Hey Ramza.

I've been having troubles with the status page and trying to display crit values with YEP_ExtraParamFormula. Tried on a fresh project and minimal plugins.

When first equipping gear with 5% Crit Rate and checking the status page it appears to calculate normally:

But if you navigate away from the Attributes page and back, it will no longer show the bonuses:

Hey there.

That is a weird thing going on there. Does it also happen to the hit % stat if you do the same thing to it?

I'll try to confirm if this is just a visual problem or if the stats are actually reverting too. I'm thinking its just a weird window refresh problem, but not 100% sure just now.

~Ramza

Heya.

Sorry for the late reply. Yes it appears it does happen to hit% as well. The other exparams seem to be fine, including the ones from your block suite, from my brief testing.

Ramza2 years ago (1 edit)

Hey there.

I looked into this, and after finding some weirdness with plugin order, and my shield block plugin, which I started to fix only to realize it was a plugin load order issue (whoops), I was unable to duplicate this exact problem.

If I leave the crit formula in YEP_ExtraParamFormulas as the default, the MHCrit and OHCrit values are calculated normally. If I change it to a flat value (0.1) then both of them show a 10% crit chance regardless of what's on either weapon, which I think is what should happen in that situation.

I'd need to know what you're using as your crit formula in that plugin to confirm that at least that is working.

I was unable to duplicate the menu display issue at all, though. The numbers changed to be what they should have been every time, and switching away from params, and back again did not cause them to revert to something else, even after changing equipment. I'd recommend disabling the exparam menu fix plugin, as what it does is covered in the DW_MenuExtension, and it's possible the two are interfering with each other somehow. That fix was only to be used if you wanted to show exparams like Mh Hit/crit on the parameters screen without using the menu extension plugin, which changes a lot of other stuff too.

~Ramza

Hey Ramza.

I am using the default crit formula:

(base + plus) * rate + flat

The issue still happens with exparamfix disabled. Additionally, even if I disable ExtraParamFormula, If I equip a weapon with crit chance in mainhand and navigate to the status page it appears to be fine at first:

But if I equip another crit weapon in the offhand and navigate to the status page it causes the split params to default again:

That is all with this load order:

This next part is an entirely separate issue, but it is a bit more of a concern on my part for my project in regards to exparamfix DW edition. Parry, Expertise, and the split crit/hit appear to crash the game when navigating to the attribute page even with the requisite plugins:

Removing the extra params appears to fix the crashing issue. The block/pierce params seem to be fine:

Sorry to dump all of this on you. I really appreciate you.

Ramza2 years ago (1 edit)

Heya.

I'll look into the second thing in a bit, I suspect maybe the exparamfix plugin doesn't support those exparam names, or rather the DW version of it doesn't.

As for the crit % thing, I think I'm getting somewhere on this now. I was about to make a big post with screenshots of my test project, with my plugins in all the same order and whatnot, and show you that I still couldn't reproduce the problem, but midway through typing that out, I realized one thing that might be making my test case different from yours, and that's that my test actor is wielding two different weapons. When I modified my offhand item to be wieldable in the main hand, and gave him two of those instead, I immediately reproduced your problem.

So the issue seems to be related to using two of the same weapon only. I'm not sure where in the process that would be causing an issue, because I don't think I ever remove weapon stats based on the item Id, but now that I know this much, I can continue in troubleshooting it further.

I will note that if you use item core, each weapon is unique, and this problem doesn't happen with two of the same weapon in that case, so it would appear to be some check I'm making that compares the main and offhand weapons to see if they are the same exact item, it seems.

~Ramza

edit:

Looking into it a bit more, this seems to be an issue caused by not having independent items in your project. Since you're not using item core, and weapons are not unique, the function I used to calculate MH and OH crit and hit ends up removing traits from all weapons of that ID when it does it's check. If your actor is wielding two of the same weapons, that means his crit % on each weapon is take out for each hand, resulting in it only showing his base crit %. This only happens if he's wielding the same weapon in each hand, though.

Additionally, it would be more than just a visual issue, as in combat, I use the same sort of function to temporarily remove traits from the hand not currently being swung, meaning if you have two of the same weapon equipped, it will take the crit % off both of them again, and your actual crit chance will be lower than expected.

I should be able to make a fix for this, but it'll be a bit more involved, since the trait removal thing is important to how the battle calculations work. In the meantime, if possible, using yanfly's Item Core plugin, and using independent weapons will solve this problem entirely (and allow you to use switchable 2h weapons if you want :)

Greetings.

I have uploaded new versions of the menu extension and the dual wield plugin that corrects this issue.

In the case where the actor is using two exactly identical weapons, and the dev is not using independent weapons from ItemCore, there is now a special case where a temporary object is created in $dataWeapons, which is used as a placeholder for one of the weapons when these checks are being made. After the calculations are done, the fake weapon is replaced with the original, and then it is removed from the database. This corrects the display issue on the menu scene, as well as the same issue in battle during split attacks, which you didn't report, but was caused by the same root cause as the display problem.

Check them out and let me know that everything is working for you.

Sorry, I must be doing something terribly wrong. The attributes still reset with or without item core and independent items. Also without the paramfix I can't get parry and expertise to show up:

Greetings. I cannot duplicate this problem after the update, with or without YEP_ItemCore. Although while troubleshooting it again, I found a display problem with the menu extension + extraparamformula that would've made the offhand crit and hit displays wrong.

I also have no issue with using only the menu extension to display pry and xpt.

Here's a poorly done image with mspaint to show various use-cases

The plugins are the exact same (except itemcore) as yours, in the same order, with the exception of BuffsStatesCore. In your load order, shield block should be immediately after BattleEngineCore, to prevent other plugins from interfering with the stuff it adds to the battle result, but I don't think that's causing this problem for you. Note that I don't think I ever really specified where in the load order to put ParryChance, but it should probably be above BuffsStatesCore as in my order above.

ExtraParamFormula is only using the default formulas for everything in it.

StatusCore has pry and xpt alone in the fourth column, and, as you can see, I don't have the exparamfix plugin at all.

The various snippets of the equip and parameters windows show that all four permutations of having two identical weapons equipped in various ways all correctly show the crit % for each hand as they are swapped around. The flail has +70% crit rate, and the actor has 4% base.

With ItemCore and independent weapons enabled, I was unable to duplicate this in the first place using the previous versions of the menu extension plugin. I checked again just now with itemcore turned on and got the same result as above.

I imagine, since your YEP plugin versions are about the same as mine are, that this project is quite old, it's possible there might be a problem with your core plugin files being out of date, messing with compatibility somehow.

I would suggest trying to reproduce this problem in a blank new project, with those plugins alone, and see if the problem still happens there. The last time someone reported weird problems like this with dual wield, it turned out their core files were woefully out of date, and updating them fixed the problem.

It's also possible that changes were made to some of your core plugin files, or some of the yanfly plugins you're using that are breaking compatibility with mine. Like I said, I'd start by making a fresh project, making Harold a dual wielder, and testing from there.

Hey Ramza. Thanks for your patience. I started a new project from about as scratch as it gets.

Fresh MV 1.6.2 install, verified rpg_core and associated files have 1.6.2 in the header and are completely unmodified from fresh install.

Redownloaded entire fresh Yanfly Library from Itch.

Redownloaded fresh chad Ramza suite from Itch.

Started New project. Ensured the name was Project1 and had Theme6 title music, because we are sophisticated around here.

1. Parry and Expertise only show in the status menu if "Show Block Chance" is set to true.

2. If "Split Attack" is set to false then mh/oh//hit/cri and pry/xpt will not show in the status menu.

3. With the fresh install, the split crit/hit params don't revert anymore so I'll have to narrow that down myself somehow. I did notice the non-split crit param did revert though, which might be misleading for non dual wield skills.

These points, may be by design. But I feel that some projects, mine included, would prefer to pick and choose displayed stats and keep a singular Attack Parameter, or otherwise opt to not show block with the main parameters, and just keep it on the attribute/exparam page. This is also why I am personally interested in the "exparamfix DW edition", as it is much closer to my specific needs.

Thanks for your time :)

Thanks for the detailed report.

I was unaware you were not using the split attack parameter, so I didn't think to look into that as the cause of those problems. I'll see what I can find about the normal crit % reverting on its own too.

I'll look into changing the extension to show those params regardless of show block, or split attack being enabled. That's honestly how it should have been to begin with, and I probably bungled something up during an update a while back that no one noticed until you came along, lol.

Rakon2 years ago

Hey Ramza! Dipped my toe into this plugin and it works well so far. But there are two little things I want to do with it.

I have a character who can eqip 3 different weapon types, these are swords, claws and chakrams. The sword is a one handed weapon and can be equipped with a shield. everything fine.

The other two should be weapons for dual wield like 2 metalclaws etc.

Now to the problem. If I equip just one claw, I´m able to equip a shield, but I just want to give the option to just equip another claws. Is this possible? Maybe I´m overlooking something^^

You know, I don't think you can actually do that.

I'd never considered the possibility that someone would want to prevent equipping a shield with certain offhand weapons, and even the tags that prevent a weapon from being equipped with specific other wtypes doesn't include locking out shields for that wtype.

I thought just now that maybe you could workaround this by disallowing the shield armor via the traits box on the claw weapons, but it turns out you can only allow equipment from that box, not disallow it.

I'll have to add this function in the next update.

~Ramza

Rakon2 years ago

Awesome that you wanna add this function, thank you!

I took a look at the <Forbidden Wtypes: x y z> function and it turns out when you have a claw in you your offhand equipped, you can only select claws for the mainhand. This works fine as the description of the function says, but wouldn´t it be nicer if you could select also all the other weapons the character could equip?

Lets say you have a claw in your offhand, it still let´s you equip all the other possoble weapons in the mainhand, but if it´s not a claw ether, it should clear out the offhand. With this version the player could always see all the weapons he can use on the character.

Maybe this is an interesting mechanic you wanna add? But it is not really an important one xD

Greetings.

I have uploaded a new version of the dual wield plugin which fixed a bug, and also added the two features we talked about here.

<Forbidden wtypes: x, y, z> can now be placed on shields, allowing you to specify weapons that cannot be used together with specific shields.

I also added a plugin parameter to show forbidden weapons in the mainhand slot, if they're being forbidden by the item in the offhand. Equipping a forbidden weapon into the main hand when the offhand forbids it will unequip the offhand item, which is functionally the same thing it does when you equip a two-handed weapon in the offhand.

Rakon2 years ago

Hello Ramza,

Unfortunately the <Forbidden wtypes: x, y, z> do not work anymore for weapons. I tested it on the previous version and it worked, on the new update don´t.

The new features work fine, thank you for that!^^

Ramza2 years ago (1 edit)

I'll take a closer look at this in the next couple of days. I didn't really change much about how the actual function worked when I added it to shields, so either I made a typo there, or it maybe never quite worked right to begin with XD

recoculous2 years ago

Overall, this is working great for me. However, it doesn't seem to work with characters that have +1 attack. They still only have two attacks when using two weapons.

Hello there.

Turns out, that is a quirk with how I added the extra attack. It might actually even be a bug, now that I think about it. The extra dual wielding attack is just given to the actor as if he had Attacks+1 on him, but is not calculated in the same way, so giving him another attacks+1 trait does not give him a third hit.

I think this is just a logic problem on my part. I accomplished this by changing the function where it returns the number of attacks+ the actor has, to return either 1 or their attacks+ number, instead of 0 or their attacks+ number. Meaning if the two numbers are both one, it will still only do one extra attack.

Line 891 in the latest version of the dual wield plugin is where this happens:

return Math.max(this.traitsSumAll(Game_BattlerBase.TRAIT_ATTACK_TIMES), 1)

if you change that line to read the following, it will fix the problem:

return Math.max(this.traitsSumAll(Game_BattlerBase.TRAIT_ATTACK_TIMES)+ 1, 1);

-Ramza

recoculous2 years ago

Very cool, thanks!

recoculous2 years ago (2 edits)

Hi, everything has worked well for me for a long time, but all of a sudden I started getting a setObject undefined error.

The game was working again when I turned your plugins off.

Do you see anything wrong with my plugin order? It is easy to move something in the plugin order without noticing sometimes.

Edit: The newest plugins I added were for Victory Aftermath & Aftermath Level Up, but I don't see those mentioned in the error log. I can't remember when I added them and I don't think it was in the middle of the current save file.

(Edit: I disabled Victory Aftermath plugins and the same error occurred.)

recoculous2 years ago

Here's the error message I got.

recoculous2 years ago (2 edits)

I made a new game and I ran into a slightly different error. Two possible issues:

One, an ally has zero equippable weapon slots and I gave them dual wielding. I assumed it would just think they are bare-handed.

Two, their weapon's unleashed default attack was missing an action sequence that would enable it to be used as a duel wielding skill. (The regular attack is also missing that action sequence, but it works, and I don't know how all of these things are handled.)

My current guess is that the first one is the problem and I am testing it now.

Edit (2-5-2022): I think I solved the problem. I played the old save state that was giving me a problem and it seems to work now. I am guessing the first solution worked.

You might want to warn people that Equip Core can cause issues if you don't want to find a work-around for the issue.

Hey there.

While the problem you encountered was definitely an issue that didn't happen without my plugin, the reason it caused an error in the first place was because of the misconfiguration of EquipCore, not because of something wrong with Dual Wield. There is a note in the documentation (or I think there is anyway) that advises to make sure you've actually given the actor the dual wield equip type, and not just given them two weapon slots via equip core, otherwise you'd have problems.

By taking away all of their weapon slots, the bit of code that swaps weapons around gets confused and doesn't know what it's doing anymore, causing the crash. Technically that could be considered an issue with my plugin, but the default state would be to always have at least one weapon slot , so it'd usually be safe to assume that the actor has at least one.

Also, it looks like the version of the menu extension you're using is a little bit older, as the line it references in the crash does not match with that function in the latest version. I'm not saying you should update it, but the latest version does fix a display issue with YEP_ExtraParamControl which you are using.

~Ramza

R4YN4 Tiyaga Grimaude2 years ago

Hello, I am considering making a purchase of this for a project me and my sister Alice are working on, and in the project we plan to have characters with multiple sets of limbs. How well does this plugin handle actors with like, 4, 6, 8…etc weapon/shield slots?

R4YN4 Tiyaga Grimaude2 years ago

Hey there.

While I haven't personally tried it for such a purpose I can say that it is very unlikely to work for this purpose. The only way it functions is if the actor is set as dual wielding, which only gives you two weapon slots by default, meaning you'd need to have used a plugin like EquipCore to get extra weapon slots on top of those two, or you'd need to have had another plugin modify the dual wield equip type to give extra weapon slots.

In either case, this plugin expects only a maximum of two weapons, so it would only ever strike twice, and each hit would ignore the stats of only one of the multiple weapons being wielded, the others would be treated as armor, most likely.

Even if you had someone modify it so that it attacked once for each weapon, instead of hardcoding to twice if dual wielding, there'd still be many other functions and effects that would need to be tweaked to make it work.

I'm not saying it isn't possible to modify it to make it work like that, but it's not something it will do out of the box.

~Ramza

Okay, thank you for the reply! I think finding a workaround would be something we’ll try.

Hi Ramza, I purchased your plugin today and am enjoying working with it, however, I am running into an issue where my characters attack and the damage dealt is equal to just the weapon's attack power minus the enemy's defense without any regard for my attack formula. For example, I have a longsword item that adds a +5 bonus to attack and when using it for a dual wield attack it only deals the 5 damage to enemy rather than the amount that should be dealt as determined by my attack formula.

I am using Yanfly's BaseParamControl plugin and my formula for attacking is - (base + plus + user.mat) * paramRate * buffRate + flat - as I am using the magic attack stat (represented by user.mat) as a flat addition to my character's attack stat. Attacks are working normally when the actor performing the attack doesn't have dual attack slots enabled but do not work correctly when the character is dual wielding or is equipped with an item with the <twohanded> note tag included with your plugin. The dualwield, twohanded and offhand damage modifier parameters in the plugin are also having no effect on the damage dealt. I think there is some sort of issue preventing these modifiers from working correctly with my attack formula.

In my plugin list I have your plugin beneath the YEP_baseparamcontrol and YEP_BattleEnginecore. I am still very new to RPGMaker MV so if there's any more information you need, or if I'm being too confusing with my explanation just let me know.

Thanks for any help you can offer.

Greetings.

I haven't tested this plugin with baseparamcontrol, but I don't think that's the issue here, or not exactly, anyway.

What is the actual damage formula of the skill being used? This plugin automatically replaces a.atk (or user.atk) with a special calculation depending on which hand is being used. I suspect that calculation isn't taking the baseparamcontrol into consideration, because like I said, I haven't exactly tested with it. If your damage calculation is something like (a.atk - b.def) -a.mat it could end up returning a weird value that ends up being zero somehow, and results in only your mat being used.

Hi, thank you for the fast reply!

The exact formula of the skill being used as a normal attack (in the skill screen) is just ( a.atk - b.def).

I don't know if this is helpful but the formula in the parameters of baseparamcontrol is read as (base + plus + user.mat) * paramRate * buffRate + flat). On my class screen in the database menu I have the standard atk of each class set to 1 for every level with a -1 modifier notetag from the Yanfly plugin so that in theory the attack stat is determined entirely by the Mat + weapon modifier + any skills/buffs.

Are you thinking that your plugin is only factoring in the actual atk stat (in this case 0 + the weapon atk bonus) and completely ignoring the formula in the baseparamcontrol plugin?

Thanks again

That sounds like a pretty good idea of what the problem is, yeah.

Are you also using the menu extension plugin? The equip scene will show the calculated atk values for each hand if you are, which would help show off the problem without actually having to hit something to test.

I'll look into the compatibility with the baseparam plugin, I expect it's a simple fix, I just need to add a check to see if the plugin is installed and then look at that atk value instead of the default actor one.

Hi again Ramza, I installed the menu plugin as you suggested and it confirmed that the attack formula is not being properly factored into the totals.

I also tried recreating my setup in your demo file and it seems to run into the same problem. Only the base attack stat and weapon strength are being factored in and not the value from the baseparam formula and the offhand duelwielding damage modifiers are not having any effect. The only plugin I added to the demo was baseparamcontrol underneath the coreengine plugin and I was using the same formula of adding the Mat stat into the atk.

As an aside, your menu plugin looks great and has some functionality I was actually looking for earlier in other plugins so thanks for suggesting I try it!

Quick amendment. As a test I raised the base attack of the character above 1. The damage modifier parameters are working, but only on the base attack and not on the bonus from the weapon itself (ie with an offhand penalty of %50 my base attack of 4 becomes 2 while the +5 from the sword stays as a +5).

Ramza3 years ago (2 edits)

Greetings.

As I expected, my formula for calculating main and offhand attack values were ignoring any formulas you'd set in BaseParamControl, instead using the default formula (base + plus) * paramRate * buffRate + flat. I corrected this issue by using the real base value in my plugin, and then removing the attack values of the opposite weapon, rather than calculate an entirely new value based on the default formula.

I am not 100% sure that this will completely work in your specific case, though, as the mat of equipped weapons doesn't play into the mainhand/offhand calculation, so it may end up giving the mat bonus from both weapons on both the main and offhand hit. I did use your example formula, though I didn't reduce atk to 0, and it did appear to split correctly though, so let me know how that goes.

You can download the updated version of the plugin from the main store page, or from this devlog.

-Ramza

Greetings Ramza, recently, I created a new project which uses your Dual-Wield and Block+Parry Chance plugins. However, it crashes if I have YEP Extra Parameter Formula plugin on, and after I turn that off, for some reason, Parry and Expertise are not showing up (also, the earlier issue I reported a month ago, somehow disappeared in the new project).

I am still trying to play around with the plugins to try and figure out if something else is conflicting, but not sure if you have any idea what might be the cause of the params not showing up (the area where they should be is simply left blank)?

Hey there.

The menu extension is needed for Parry and expertise to be shown on the menu, if it's not there (or it's crashed before the project loads, causing it to not load at all) the YEP menu will not know how to interpret the requested parameters and draw a blank line instead.

Check the console for any errors, sometimes a crash on load just causes the plugin to abort loading instead of straight crashing the project.

Also, please share the crash message (and console stuff) from when it crashes with YEP_ExtraParamFormula as well. I've a couple of crashes from that thing over a long time, and I suspect I know what it is, but I need the errors to troubleshoot.

Hi Ramza, thanks for the response. Here is the crash report from the console for the Extra Param.

I checked the console without the extra paramters, and there is no errors. Block Chance shows up perfectly fine. It's only Parry Chance that is the issue.

Not sure if plugin order is to be blamed.

Ramza3 years ago (3 edits)

Hello again.

I've gotten a chance to start to look into this for you and I need a couple of questions answered before I can continue to troubleshoot.

I don't see the dual wield plugin in your list. Are you using that? You must be since the crash error is coming from the dual wield extension, which throws an error if you try to use it without the dual wield plugin.

I can't duplicate the issue with mhpry and ohpry and xpt not showing up on that screen myself, but since I can't see where you're loading the menu extension in the order, I suspect it's being overwritten by the YEP_StatusMenuCore plugin, since I can't see that one either. Load StatusMenuCore before the menu extension and that should sort that problem out.

Looks like the crash that is happening is somehow related to splitting the hit and crit params for dual wielding. I am familiar with this particular error from porting the block plugin to RMMZ, as the extraparamformulas plugin features are included in one of the default VS plugins for MZ. I fixed a similar crash in MV related to block rate already, so I suspect the issue is caused by something similar. I'll get back to you on this shortly.

edit:

Okay, I can't duplicate the crash at all, but looking at the line the crash is coming from, I can see what the problem is, though not how it is caused.

In a fix I posted in v1.39 or v1.40, I fixed an issue where people using the extraparamformulas plugin would see incorrect values for hit and crit when showing the main and offhands. This fix expressly assumed that the scene would always have an actor in it, because if it didn't, how would it be displaying any information at all? Well apparently in some (unknown to me) case, this very thing was happening, so it was causing that crash error when it tried to draw the mhhit value for you.

I have posted a fix that should resolve this.

-Ramza

Hi Ramza, thanks for the response. I tried the latest plugin, and there is still an error. The crash happens when I move to a dual wield character's Attributes only.

I also tried turning off the Extra Param plugin. When that happens, Hit% displays fine, but Parry Chance and Expertise does not. With this, I tried turning off SRD Super Tools and ICF-Soft Menu, but no help. Not sure if it is the plugin order, but I moved the Menu Extension to above ICF-Soft Menu's plugin and it still does not work.

Below is a list of plugins I have in excel for reference.

Hello again.

I can't duplicate the crash on my own test project with the following plugins in the following order:

That means that the problem is either load order, or an issue with a third plugin interfering with one or both of the other two. I know this is a huge pain in the butt, but could it be possible for you to try to duplicate this problem in a fresh project? I've tried myself in the test project I use to roll out updates and haven't had any luck myself.

Hi Ramza, sorry, another question. If I am using a custom menu plugin (e.g. ICF-Soft's YEPShow Params), what is the short name to call the main or off hand's attack, respectively, to show as a param? The reason I am asking is because ICF-Soft's plugin conflicts with yours, and I tried mhcalc and ohcalc, but it's not working. Looking forward to your response. Thanks in advance.

MHCalc() and OHCalc() should work for this. Make sure to include the brackets, as it is a function that returns the value, not the value itself.

I'm not sure how that plugin gets its values, but those functions are on all Game_Actor objects, so that should be what you need.

zelanius3 years ago (1 edit)

Hi Ramza, thanks for the reply. The plugin calls the shortname of the param as it appears in the damage formula (e.g. agi, luk, etc). It, unfortunately, looks like it will remain incompatible (although I can still show main and offhand attack in the "General" section of YEP's Status Menu by keeping the default; in fact the other plugin can't seem to override this section). I have written to the plugin author on this, as their plugin seems largely compatible with a lot of plugins, just not functions like yours.

Zerato20203 years ago

Hey Ramza, I purchased your plugin last year and works great. But I have one issue. My duel wield attacks, even after the enemy is gone. Is there a way to stop attacking once the enemy is dead? sorry for the nube question

Hi there.

Someone asked this question before, and my experimenting with a workaround to make it work for them actually led to me incorrectly thinking I had a weird bug in a newer version.

There is no way to prevent the second attack in the case that an enemy dies after the first one, not within this plugin, anyway. The way the attack times + trait is programmed is that it just repeats the target action section multiple times, as if it were all part of the same sequence. It doesn't do a check in between. My plugin simply hooks into this, and swaps weapon stats around (and images) when the second attack is made.

What you can do is make your attack sequence check to see if the target is dead first, and not do anything in the target section at all. This will cause the second attack to not happen if the first killed the target, but it has another issue in that action sequences that already contain and if check will not work, as they can't be nested. You could get around this with a different plugin (like this one by SergeofBIBEK).

If you're not using Yanfly's action sequences plugins at all, you'll need those in order to make this change first.

If you're already using an action sequence, simply wrap the target action in a check to see if the target is dead, and if it is, do nothing:

before:

<target action>
motion attack: user
wait: 12
attack animation: target
wait: 3
action effect: target
wait for animation
</target action>

after:

<target action>
if (target.hp > 0)
    motion attack: user
    wait: 12
    attack animation: target
    wait: 3
    action effect: target
    wait for animation
end
</target action>

Like I said above, if your sequence already has an if check in it, nesting them doesn't work, but you can fix that with the plugin I linked.

-Ramza

Zerato20203 years ago(+1)

Thank you so much! I use Yanfly of course. I've used the link you sent and it seems to do the trick! Love your shield plugin btw!

Hi Ramza, wanted to check, is this or your other plugins compatible with YEP's Stat Allocation? I was reading through the tutorial and it does not make any mention of this plugin anywhere. Appreciate your advise. Thanks in advance!

Hi there.

I haven't tested that plugin specifically, but here's what I can gleam by looking at it:

It should be mechanically compatible. Stat points spent in ATK will apply correctly to both main and offhand attack values.
- It might be possible that ATK added from this might not be multiplied by the offhand or two-handed multipliers, I think it should work, but, like I said, I haven't tested it. The multiplier is added after other effects that modify the base param, so it should apply after this plugin.
The scene showing the stat purchasing should only show base params, and by looking at the video for this plugin, it doesn't appear to be reusing one of the scenes I directly modified, so it should continue to do this, and will not show the split params in this window.
As above, because this window doesn't show the split params at all, there should be no issue with a blank slot, or Block Chance showing up on this scene either, if you're using that plugin as well.

In conclusion, it should work, but it hasn't been tested. There's no reason why it shouldn't work, and any incompatibilities would be minor, and pretty easy for me to fix if someone were to report any.

-Ramza

Hi Ramza, many thanks! Will try it out.

Hi Ramza, I did some testing, including with the Block Chance, Parry, and Switchable plugins and everything worked fine. However, as soon as I start using the Menu Extension (both with and without the exparamfix), I got the below message. I think I can live without the Menu Extension, but just highlighting the bug I received.

I just tested myself and I am unable to duplicate this issue.

It looks like, from the error message, something on screen is attempting to draw block chance. Knowing that, I imported it into my test project, and set the default parameters to include both 'blk' and 'cri' to see if xparams were what was causing the issue for you. Block Chance doesn't show up on the scene at all, which it shouldn't as the YEP plugin has no idea what 'blk' stands for, and critical hit chance shows up fine with no crash and no issue.

Load order may be the problem. This worked for me with the Yanfly plugins in the proper load order (from the website). Block Chance loads right after Battle Engine Core, Dual Wield loads at the end of the other battle plugins. The Menu extension should be in the load order near the bottom, after any other menu plugins you have. In my case it was also below stat allocation in the load order.

That expram fix plugin you're using is meant only for people who aren't using the menu extension. It adds some short codes to show on the YEP Status Menu Core scene, but the menu extension already does this, so using both might also be causing a problem.

If you're still having problems, a few more screenshots, what you are doing exactly to cause the crash, and the text from the console when it crashes (press f12 when the above crash screen happens and click 'console') will make tracking it down much easier.

Hi Ramza, thanks for the response. I am following Yanfly's order, but the rest are a bit harder to figure out. I followed your instructions, but there is still an error (though somewhat different).

I managed to remove the Galv_WeaponProf error by moving it just below YEP Battle Engine the order but I could not figure out the rest. Below are the location where I slotted in your plugins.

Ramza3 years ago(+1)

Greetings.

I still can't reproduce this on my test project, and it looks like the version of the stat allocation plugin I'm using is not the same as the one you have, as the functions throwing the error are on different lines on my version.

With that being said, I suspect the problem is the below function:

Yanfly.StatAlc.Game_BattlerBase_xparam = Game_BattlerBase.prototype.xparam;
Game_BattlerBase.prototype.xparam = function(xparamId) {
  var value = Yanfly.StatAlc.Game_BattlerBase_xparam.call(this, xparamId);
  value += this.xparamAllocationBonus(xparamId);
  return value;
};

I'm not sure at what point it is called, but it would appear that it isn't playing nice with the fact that I've defined block chance as xparamId 10. So it's looping through the normal xparams and then getting to block chance and breaking. I think if we edit the function to abort if it detects that it's on Id 10, it should be fine, but since I can't duplicate the problem myself, I can't verify if the fix actually works either.

Copy the below text into a blank .js file, and import it into your plugin manager at the bottom of the list.

Yanfly.StatAlc.Game_BattlerBase_xparam = Game_BattlerBase.prototype.xparam;
Game_BattlerBase.prototype.xparam = function(xparamId) {
  var value = Yanfly.StatAlc.Game_BattlerBase_xparam.call(this, xparamId);
  if (xparamId != 10) value += this.xparamAllocationBonus(xparamId);
  return value;
};

This will overwrite the function that I suspect is causing the issue, and should(hopefully?) fix it for you. Let me know if it doesn't work, and any new errors you get.

-Ramza

ʃən3 years ago(+1)

Hey Ramza would you consider putting on a summer/end of corona restrictions bundle together with some other creators?

Idk if I'm alone on this but I haven't gotten Irina's or Olivia's bundles bc they're both ~45 USD/60 CAD on their own. If the 3 of you had a deal going until Jun 30th/July 1st to co-op a 60 USD bundle.. I'd be willing to bet there'd be an increase in sales for each of you since more people are coming here due to the political bundles pulling in larger-than-usual sales, and catching media attention.

Granted, I'm being opportunistic and asking bc I want to support the 3 of you, but I also don't want to drop a third of a month's living expenses when 70% of my offline work was shut down á la covid/closed borders.

P.S. - I looked for a way to ask privately, but I can't DM on twitter & I haven't found an email haha. Apologies if this is a misplaced message.

Ramza3 years ago(+1)

Hello there.

I admit that I hadn't really considered such a bundle, or even a sale for the end of the pandemic. Technically, the sale I ran from April to the beginning of May was the biggest discount I had ever done, and the description definitely included some "Stay inside, make games instead" sort of language, and I don't want to have multiple sales really close together, particularly for similar reasons, because that can lead to consumer confusion, and sometimes people refunding bundles or individual plugins to buy the newest bundle as it's a slightly better deal, maybe.

Speaking of confusion, one main reason why I can't see myself doing a collaborative bundle with Irina or Olivia is that many of their plugins aren't strictly compatible with my own, and the majority of the others haven't been tested. If we somehow came together and made a giant collaborative bundle, it'd come with the caveat that several of the plugins included in it may (nay, most likely will) not be compatible with each other, and I feel like that is going to lead to large influx of people who didn't read, or didn't know, making support posts in all of our channels asking for support that we will not be able to give. And since it's particularly difficult to held hold of Irina and Olivia, and I don't think either of them do much in the way of plugin support, a lot of those posts are going to fall to me, and I simply won't be able to help.

In the end, that's probably going to lead to some refunds, realistically, and that isn't helping anyone involved. Customers get a bad taste in their mouth, the three of us get harassed, and everyone pays for it. Not to mention the possible fall-out, if word gets around that someone got a refund on the whole bundle because it wasn't compatible and they felt ripped off, maybe more people who bought the bundle get refunds too? It's a slam dunk, and then a bunch of people have some plugins they didn't even pay money for.

The other reason for not doing something like this is a bit more simple. I don't have any way to communicate with Irina or Olivia. Both of them make it very difficult to talk to them, especially about plugins. DMs on discord are blocked, and I don't share any servers in common with them that allow me to talk to either of them. If there is some sort of secret discord server that the disciples of Yanfly communicate on, I am not privy to it, unfortunately. Both of them have comments on their individual plugins turned off, and no community forum here. And both of them seem to ignore DMs and posts on the RPGMakerWeb website in their plugin support topics. With no special way for me, as a creator, to get in contact with either of them, there's no way for me to approach them and set up a deal like this in the first place. I might be open to such a deal if one of them approached me about it, but we'd have to iron out how the obvious incompatibilities of our plugins will be handled.

That being said, I appreciate the thought you put into your request, and I don't mind that it's asked publicly. For reference though, I can be reached on Discord via DM (Ramza#3215), I have a support topic linked on my profile here on the RPGMakerWeb forums as well, although that topic is kind of dead, necroposting it is alright., and I also respond to DMs on that site as well, which you don't need a certain number of posts or like to send.

ʃən3 years ago(+1)

Firstly, thank you for even considering the idea. :D And fair points all-around. I kind of ADD'd into the "What if?" and some of your points (possibility of contact, refunds, compatibility, customer confusion) I hadn't considered even tho they seem obvious on 2nd read.

Secondly, my apologies. I missed your sale and just jumped into "Maybe it hasn't happened before?" Thank you for pointing out you've already -- and recently -- had a larger sale. More due diligence on my part for next time an idea bubbles up.

Finally, idk how often you're told this as a creator or just human-to-human, you're an awesome person. The values you appear to rep, the way you handled a weird question, reply time etc. I didn't expect to feel good after asking a question, yet I feel amazing. That's something I'm going to work on passing on when I create the useful/fun things. :P Ehm, thank you for being you haha

Ramza3 years ago(+1)

Hey, thanks!

I don't personally feel like I'm doing anything special here, just acting as I think everyone should, but it's good to hear that people appreciate it! Sorry you missed the sale, but itch.io usually does a summer sale too, and I'm sure I'll have something on there to your liking ;)

Keep doing what you do! I'm looking forward to testing out the waves of projects coming out that use my plugins. It helps me cope with the fact that I never seem to release anything of my own!

-Ramza

KFDirector3 years ago

Ramza, while under most circumstances I wouldn't want to change this - the plugin has worked great for its clearly intended cases! - is it possible to disable or evade the functionality where, while attacking with one weapon, the stats from the other weapon are ignored (I think the code treats it like you've unequipped the other weapon)?

I'm considering a specific use case like West of Loathing, where the player has equipped both a melee weapon and a gun, gets what what is effectively a FIGHT command for each weapon (using only the damage formula for each), may have skills that key off of the damage formulas specific to either weapon, but still always gets to retain the stat boosts from each weapon. It seems I could do all of that with Dual Wield and Weapon Formulas, except that at the very moment of attack one would un-equip one of the weapons.

Hmm.

I think the disable state might be what you want to use here. When it's on a battler the split attack (and the extra hit) don't function at all, so the weapon unequipping shouldn't happen either. Since you're using specific attack skills to attack with the main and offhand weapon, using a.MHCalc() and a.OHCalc() in place of a.atk in the formula for those skills should split damage correctly as well. You might need to do some weird workaround in your action sequence to get the offhand weapon to show up correctly during the action sequence for that skill though.

powerstranger3 years ago

Hey Ramza, I'm having an issue where with the newest version of dual wield installed, certain weapons will only deal 0 damage. In previous versions I had the issue when the dual wield/two hand modifiers weren't 1, but now even when it's 1 it returns 0. Is there any fix for this?