Post by Tarwix in Requests

Viewing post in Requests

Can you look into making a tiny (I hope) core patch that fixes the easily thousands of warning messages that show up in the console log when playing a browser build on itch.io, which read something like:

"The provided value 'undefined' is not a valid enum value of type CanvasTextAlign."
from Bitmap.drawText @ rpg_core.js:1348
Bitmap.drawText @ YEP_CoreEngine.js:1031
Window_Base.processNormalCharacter @ rpg_windows.js:327
Window_Base.processCharacter @ rpg_windows.js:319
Window_Message.updateMessage @ rpg_windows.js:4411
<snip>

and occur for every character of text written to the screen, except for the map name. I've seen this in both my own and other people's games.

Tamschi2 days ago(+1)

Done. I’ll update the page in a moment, but the file is there.

(Untested, but it’s a really simple issue and I’m quite confident.)

Tamschi2 days ago(+1)

It’s Bitmap.drawText CanvasTextAlign Default Fix / TSk_Bitmap_drawText_CanvasTextAlign_Default_Fix.js, to be specific.

Note that I defaulted it to ‘start’ instead of ‘left’ since I think that’s what the web API does internally when that error occurs.

Tarwix1 day ago

So far, this seems to be working almost entirely as expected. Only thing I've seen is warnings of
The provided value '36' is not a valid enum value of type CanvasTextAlign.
which happens in the Equip screen 5 times each time a different Actor is displayed, apparently once for each equipment slot that's visible, or when the list of slots scrolls (my game has a 6th slot that's always empty for now). If you want a call stack, let me know.

There's also occasional "[Violation] 'requestAnimationFrame' handler took ###ms" with various values that I don't remember happening before.

But that's still immeasurably better than a warning for each text character sent to the screen.

THANK YOU!

Tamschi1 day ago

A call stack would help, but a a 36 appearing there sounds like someone is calling drawText on Window_Base as if it was the method on Bitmap. The former doesn’t have a lineHeight parameter preceding align.

I’m pretty certain that this line here in Window_EquipSlot.prototype.drawItem is the culprit:
this.drawText(this.slotName(index), rect.x, rect.y, 138, this.lineHeight());

The bug is present in both MV and MZ, but fixed in the YEP_EquipCore.

You can just delete the , this.lineHeight() part there to fix this, but I’ll make plugin to auto-check that argument tomorrow, too.

Tamschi1 day ago(+1)

This is now available as Window_Base.drawText Ignore CanvasTextAlign Numbers.

Tarwix1 day ago

Tested and working as expected, too. THANKS!

Tamschi1 day ago (1 edit)

You’re welcome, it only took a few minutes to find with your description.

If you’d like to help me out in return, please consider mentioning me to other RPG devs you know. My plugins aren’t flashy, so the grapevine seems to be more effective for actually getting eyes on what I make 🤔

Tamschi1 day ago

Regarding ”[Violation] ‘requestAnimationFrame’ handler took ###ms”, that’s a performance warning with unspecific cause. It means something took too much time and caused a lag frame.

You can figure this one out using the profiler, but usually it’s just something like resource loading not running in parallel.