Post by pyro944 in Portrait Pack Editor for Conquest

Viewing post in Portrait Pack Editor for Conquest

The new logic seems to be treating the `/` as a kind of tag.

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException: Cannot invoke "java.util.List.iterator()" because the return value of "java.util.Map.get(Object)" is null

at com.CyanCorn.portrait.main.PortraitObject.doesThisCategoryHaveThisString(PortraitObject.java:355)

at com.CyanCorn.portrait.main.PortraitObject.getMyTagsFromThisCategory(PortraitObject.java:347)

at com.CyanCorn.portrait.main.PortraitObject.apply(PortraitObject.java:322)

at com.CyanCorn.portrait.main.PortraitObject.setMetaData(PortraitObject.java:399)

at com.CyanCorn.portrait.GUI.GUIFactory.applyButtonClicked(GUIFactory.java:1343)

Specifically, that line is looking for a key named `/` instead of one of the actual tag names (like `Races`). It's likely that PortraitObject.apply needs to be updated to handle `/` instead of `\\`. It also wouldn't hurt to throw a little null safety in there.

This bug might also affect Windows, now that I think about it.

IsaacG145 days ago

OK, I think I fixed it 2.24 (should have checked email instead of gaming...)

but my confidence is shattered

Here is the source code if you're interested

https://www.mediafire.com/file/tyoekyhx4xzovyc/PortraitPackEditorRe_SRC.zip/file

pyro944144 days ago

It just needed a minor change. Here's a patch: https://pastebin.com/SUsNdKn6

The only important change is to GUIFactory. The other changes were just necessary to let me build and run the project in IntelliJ.

This should be compatible with all platforms, but I suggest you give it a quick spin on Windows, particularly paying attention to the save path when you press Apply.

IsaacG140 days ago

Ok, I tried it in Windows

Works afaik

So if it works on your end, it's now compatible

Thank you

(this delay is why I was trying to fix it quickly before, I knew I'd be gone a few days)

itch.io

Viewing post in Portrait Pack Editor for Conquest