Post by Raskoljnikov in Update comments

Viewing post in Update comments

Unfortunately it didn't fix telescope. Can it be related to the fact that in original NH mod and POTC you press Ctrl key only one time to activate the telescope, and pressing it again deactivates it.

ChezJfrey4 years ago (1 edit)

I don't know. I started a game, but do not have a telescope, so I can't check. But there are tons of errors and frankly, I'm not even sure how the game can even play properly, given the script code I see. They made a global ref pchar variable, but in all the functions, they instead assign a local pchar variable. Then, in some of the scripts where they try to use pchar, but in those cases didn't make a local var, the global pchar they try to use in those instances is invalid. I fixed that by assigning the global pchar in seadogs.c, which fixed most of that, but now I see some index out-of-bounds errors in AIShip.c and flags.c, and missing references in MAXIMUS_Functions.c. They have a wrong function name in TempQuestEnemy.c, which also has the wrong parameter type, wrong return value for their dynamic call. I'm done trying to fix their script problems, because these have nothing to do with the port to the new engine, but rather mistakes in their code.

The global vs. local pchar is why the worldmap engagement screen did not present. Anyway, here is what I have:

https://mega.nz/folder/DtcEmR6C#pjia47ERTPh1EoLClQMfOg

File is NH2018.zip and it contains only some changed files.

Raskoljnikov4 years ago

are these script errors affecting the original NH game in Storm engine 2.0 or they only affect Maelstrom engine?

ChezJfrey4 years ago

They should be a problem no matter what engine. If these are not presenting errors in 2.0, then I can only guess the script code I was supplied is not the same.

Raskoljnikov4 years ago

All the scripts are from the original New Horizons mod from theri official site. So I guess it works that way. Now that it is running Maelstrom, is it possible to implement the blood like in Storm engine 2.8?

ChezJfrey4 years ago (1 edit)

Just as an example for TempQuestEnemy.c. The code in characters_init.c tries to dynamically load a .c file, and dynamically call a function:

if (FindFile("PROGRAM\Characters\init", "*.c", fname) != "") {
        if (LoadSegment("Characters\init\" + fname)) {
            call func(&n);
            UnloadSegment("Characters\init\" + fname);
        }
}

In the case of the problem, fname is "TempQuestEnemy.c" and func = "CreateTempQuestEnemyCharacters". So it will try to call that function after it loads the .c file. But in that TempQuestEnemy.c file, there is no function in the script I have from you. It looks like this:

int CreateTempQuestEnemy(int n)

Notice that it is the wrong name, and also does not pass a reference type for &n, but rather an int n. It should look like this:

void CreateTempQuestEnemyCharacters(ref n)

What happens with that original script is nothing happens and an error is logged that it can't find function CreateTempQuestEnemyCharacters in TempQuestEnemy.c. That is not a porting problem and should not work no matter if it is Storm 2.0, Storm 2.8 or Maelstrom.

Raskoljnikov4 years ago

This is interesting, but makes sense since a lot of people worked on that mod. I will check the original program folder as soon as I get home.

Raskoljnikov4 years ago (1 edit)

This PROGRAM folder is from original New Horizons mod for 2.0 engine. I compared it and it has 2.547 files, while the one I have now has 4.393. Is it possible that some files are obsolete?

https://mega.nz/file/9DQ0gZKa#mdfJ3ekLJuMaOYZkq5HTprotUmRwk3VZlC-aF2hLCtA

ChezJfrey4 years ago

Obsolete files don't hurt anything if the references to them are removed from #include and they are never run. So obsolete files, even with errors, don't cause problems.

Raskoljnikov4 years ago

I started over with clean PROGRAM folder from NH 2018 build, fixed the libriary syntax erros. The game starts, loads the PA! splash video and then just black screen. Error log shows this: