Post by ChezJfrey in Update comments - itch.io

Update » Comments

Viewing post in Update comments

↑ View parent post

ChezJfrey4 years ago (1 edit)

For instance, referring to my other post about comparing, that utilite.c file from the 2016 NH needed some changes to work with 2.8 and Maelstrom, where these lines needed add:

native string DialogAssembleStr(string idStr, string paramStr);
native string DialogAddParamToStr(string oldParamStr, string paramID, string paramValue);
native void XI_MakeNode(string sIniFileName, string sNodeType, string sNodeName, int nPriority); 
native void XI_DeleteNode(string sNodeName); native bool XI_IsWindowEnable(string sWindowName); 
native void XI_WindowShow(string sWindowName, int bShowStatus); 
native void XI_WindowDisable(string sWindowName, int bDisableStatus); 
native void XI_WindowAddNode(string sWindowName, string sNodeName); 
native int XI_StoreNodeLocksWithOff(); native void XI_RestoreNodeLocks(int nStoreCode); 
native bool XI_IsKeyPressed(string key_name); // key_name = {"shift","control","alt"} 
native void XI_RegistryExitKey(string key_name);

And this line needed change:

#library "script_interface_functions"

Raskoljnikov4 years ago

Do you happen to know how to fix this?

COMPILE ERROR - file: seadogs.c; line: 508

Undeclared identifier: PChar

ChezJfrey4 years ago

Declare it somewhere at the global scope. In the 2018 version you supplied me, it was on line 19 of globals.c, just after these 2 lines:

float FRAND(float _x) { return rand(32768) / 32768.0 * _x; }

float frandSmall(float _x) { return rand(32) / 32.0 * _x; } // boal

ref pchar;

Raskoljnikov4 years ago

Now I get a bunch of new errors:

COMPILE ERROR - file: locations\locations.c; line: 19

native function 'SetTipsEnabled' not declared

COMPILE ERROR - file: battle_interface\utils.c; line: 7

native function 'ShipSailState' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'LanguageGetDefaultLanguage' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'GetSaveDirectory' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'GetProgramDirectory' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'GetResourceDirectory' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'XI_MakeNode' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'XI_DeleteNode' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'XI_WindowShow' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'XI_WindowDisable' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'XI_IsWindowEnable' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'XI_WindowAddNode' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'DialogAssembleStr' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'DialogAddParamToStr' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'XI_StoreNodeLocksWithOff' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'XI_RestoreNodeLocks' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'XI_IsKeyPressed' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'XI_RegistryExitKey' not declared

COMPILE ERROR - file: interface\utilite.c; line: 16

native function 'AddControlTreeNode' not declared

RUNTIME ERROR - file: battle_interface\loginterface.c; line: 31

Can't create class: ActionIntrface

RUNTIME ERROR - file: ships\ships_init.c; line: 210

Invalid function call

RUNTIME ERROR - file: ships\ships_init.c; line: 210

function 'InitShips' stack error

Can't get to Start Menu still, but the game starts loading and passes the PA! splash video. So I guess we are on a good way to making it work. Just to note that I have included the 2021 updates as well.

Raskoljnikov4 years ago

This is the updated PROGRAM folder from 19th May 2021...

https://mega.nz/file/gbgHjSqZ#nxoWGXy8TuoR3LwbRzNdsSBL7AWpNUnzaXx5PlRDzKM

Raskoljnikov4 years ago

Ok, so I fixed some of them. These are the ones that appear now:

COMPILE ERROR - file: interface\utilite.c; line: 28

native function 'LanguageGetDefaultLanguage' not declared

COMPILE ERROR - file: interface\utilite.c; line: 28

native function 'GetSaveDirectory' not declared

COMPILE ERROR - file: interface\utilite.c; line: 28

native function 'GetProgramDirectory' not declared

COMPILE ERROR - file: interface\utilite.c; line: 28

native function 'GetResourceDirectory' not declared

COMPILE ERROR - file: interface\utilite.c; line: 28

native function 'AddControlTreeNode' not declared

RUNTIME ERROR - file: ships\ships_init.c; line: 210

Invalid function call

RUNTIME ERROR - file: ships\ships_init.c; line: 210

function 'InitShips' stack error

Raskoljnikov4 years ago

Sorry for bombarding you with so many messages, but I was trying to fix all by myself. I got the game to run with 2021 build, but isn't this weird, I was trying to fix the bugs in the PROGRAM folder. when I accidentally saw the log in compiler:

ini file RESOURCE\INI\RESOURCE\INI\NEW_INTERFACES\mainmenu.ini not found!

DestroyWindow

PostDWindow

System exit and cleanup:

Mem state: User memory: 0 MSSystem: 0 Blocks: 0

I made the folders RESOURCE\INI\RESOURCE\INI\NEW_INTERFACES\mainmenu and the game got to main menu screen. Isn't that weird. Why is it needing double folders?

ChezJfrey4 years ago

Because in the New Horizons Maximus_Functions.c, the void ReinitInterface sets the .IniFile path like this:

Interfaces[INTERFACE_SELECT_STORYLINE].IniFile = "RESOURCE\INI\"+GetCurrentInterfacePath()+"\select_storyline.ini";

But Maelstrom already knows for any Interfaces object, the .Inifile path will always be the default RESOURCE path (specified in start.ini), so it is redundant. If you compare the 2016 version of that same file/function, all the "RESOURCE\INI\" portions were removed for Maelstrom. Keep in mind, that is not the only place in the scripts where this type of problem will occur, so you need to search all the file contents for similar issues.

ChezJfrey4 years ago

I still suggest going through a 2018 (the working copy I gave just recently) and the 2021 version, and comparing all the different files.

Using FreeFileSync, not counting the new files that would be added, there are 951 files that are different:

Then you have to go through every one of them, compare them, and modify what is different in the 2018 working version, that is specific to making it work with Maelstrom. Here is that MAXIMUS comparison:

Some things are because they were Storm 2.8 fixes, like replacing all ResetSoundScheme(); calls in every file except sound.c, with ResetSound();

There are lots of things, but the only way to find them all is compare those 900+ files to be sure you get them all. Then in the case of things like the ResetSoundScheme thing, is to do a global search of all the files, because some files are newly added and there is no comparison to do, and if they contain things that we know need to change, you have to search for them.

Raskoljnikov4 years ago

Ok, will do that now.

Raskoljnikov4 years ago

Ok, so I updated to the latest build from May 2021. I spent last 2 days fixing all the script errors. I think I fixed them all, except the one in utils.c:

RUNTIME ERROR - file: utils.c; line: 2091

function 'GetStoryline' stack error

RUNTIME ERROR - file: utils.c; line: 2091

function 'GetStoryline' stack error

RUNTIME ERROR - file: utils.c; line: 2091

function 'GetStoryline' stack error

I just don't get it why GetStoryline is bad code, when it appears in different files as well.

Here's the updated Resource and Program folder:

https://mega.nz/file/1GoEiL5D#GAKiPDQFsoPzNFgXly6o-mBPcrCV7lkVDEWE_3l4qcc

https://mega.nz/file/oSgwiBwC#O5qG-vBnGNxrjHoGWQdV6pzXEOE1WJgukj70un8lqDY

ChezJfrey4 years ago

It's because they screwed up in INTERFACE\select_storyline.c:

CharFirstName = GetStoryline(slno, CharFirstName);
CharMiddleName = GetStoryline(slno, CharMiddleName);
CharLastName = GetStoryline(slno, CharLastName);

Should be:

CharFirstName = GetStorylineVar(slno, CharFirstName);
CharMiddleName = GetStorylineVar(slno, CharMiddleName);
CharLastName = GetStorylineVar(slno, CharLastName);

The New Horizons modders wrote the functions GetStoryLine or GetStoryLineVar; they are not a part of COAS, GOF or ERAS. So I really don't want to spend my time debugging and troubleshooting errors they have made. I will sometimes help add or extend features for Maelstrom to work with it, like I did for the Flag and multiple display Log messages it uses...things like that.

Anyway, since it appears you did a fair amount of work already, I did sift through a few other files and this launches and I can start a new, default game:

https://mega.nz/folder/DtcEmR6C#pjia47ERTPh1EoLClQMfOg

Download FixesNH2021.zip

Also note that they did appear to add another command in BattleInterface.c and they may have changed/added the texture icons, but I am not going to adjust anything for that. So if icons have shifted index in the texture file, someone will have to readjust all the .pic and .selPic values. I made a note that the Triton needs to be checked //Boyer note: Need to check .picNum in texture and also add .selPicNum

Raskoljnikov4 years ago

I think that new NH modders are not very good at coding, so I won't be upgrading the mod anymore. I will focus now on fixing any bugs/conflicts that may occur due to the Engine upgrade. I will test the fixes that you provided now, and if I need any help with repositioning those buttons/icons, I hope I can count on your help :)

Raskoljnikov4 years ago

Everything seems to be working, except that I cannot hit with the sword. Firing pistol works with Q button, but clicking does nothing when I draw a sword...

ChezJfrey4 years ago

Because events were missing in Loc_ai\LAi_fightparams.c. If you compare the current 2016 version from Itch to the 2021 version, you will see a bunch of code for event_handlers added, even with a comment "//Boyer add below" which is my last name.

I made the change for you and uploaded to that same MEGA link, just the LAi_fightparams.c file by itself.

....please don't tell me I have to review all the 2021 files...I did the most obvious ones I could think of, but I really don't want to do them all.

Raskoljnikov4 years ago

No, no. i will review them. But good for letting me know about Boyer, I wasn't sure where that came from lol

Raskoljnikov4 years ago

Is it possible to add blood particles to New Horizons now that it's running Maelstrom engine, like in COAS? If possible, I just need steps which files need to be added?

View more in thread