You're doing well.
For the telescope, it looks like a parameter needs to be removed from both the function implementation in ispyglass.c for both void TelescopeInitParameters() and void setTelescopeInitParameters(aref arItmScope) and also remove the extra parameter from wherever it is called from, like CharacterUtilite.c setTelescopeInitParameters(&Telescope,arItm); and sea.c TelescopeInitParameters(&Telescope);
The following things are broken now:
telescope
Credits button in Main Menu does not show up credits video (on your 2016 build it shows up, so that's broken at the moment)
Starting a New Game with Nathaniel Hawk and Free Play game don't show initial video which is called Storm.wmv located in Resource\Videos (in your 2016 build this also works, so it's broken at the moment)
https://mega.nz/file/Eahw1aya#7aKKtnkTmMwiTIFqhbMV6ITQ5XSTOF_KYjj0yeo_VVM
This is what I have so far. Bugs that came up and didn't exist in 2016 build that you provided are the following:
telescope
Credits button in Main Menu does not show up credits video (on your 2016 build it shows up, so that's broken at the moment)
Starting a New Game with Nathaniel Hawk and Free Play game don't show initial video which is called Storm.wmv located in Resource\Videos (in your 2016 build this also works, so it's broken at the moment)
When I press SPACE button in World map, nothing happens, neither at open sea neither at ship encounters (this also works in your 2016 build)
When I want to fire ship cannons in 3rd person or 1st person mode, nothing happens (I checked cannonballs and gunpowder).
I'm also uploading the updated RESOURCES folder for you to have if needed.
Looking at the code, there is an option in New Horizons to disable/enable videos in InternalSettings.h. Set it to value 1:
#define ENABLE_VIDEOS 1
I made some various changes, but I still can't load a FreePlay game because the location doesn't load due to missing location model elements. But it should probably fix your telescope. As for the other stuff, it might be options similar to the video, but I am unfamiliar with New Horizons options and what they all might do.
Program.zip from: https://mega.nz/folder/DtcEmR6C#pjia47ERTPh1EoLClQMfOg
I don't know. I started a game, but do not have a telescope, so I can't check. But there are tons of errors and frankly, I'm not even sure how the game can even play properly, given the script code I see. They made a global ref pchar variable, but in all the functions, they instead assign a local pchar variable. Then, in some of the scripts where they try to use pchar, but in those cases didn't make a local var, the global pchar they try to use in those instances is invalid. I fixed that by assigning the global pchar in seadogs.c, which fixed most of that, but now I see some index out-of-bounds errors in AIShip.c and flags.c, and missing references in MAXIMUS_Functions.c. They have a wrong function name in TempQuestEnemy.c, which also has the wrong parameter type, wrong return value for their dynamic call. I'm done trying to fix their script problems, because these have nothing to do with the port to the new engine, but rather mistakes in their code.
The global vs. local pchar is why the worldmap engagement screen did not present. Anyway, here is what I have:
https://mega.nz/folder/DtcEmR6C#pjia47ERTPh1EoLClQMfOg
File is NH2018.zip and it contains only some changed files.
Just as an example for TempQuestEnemy.c. The code in characters_init.c tries to dynamically load a .c file, and dynamically call a function:
if (FindFile("PROGRAM\Characters\init", "*.c", fname) != "") {
if (LoadSegment("Characters\init\" + fname)) {
call func(&n);
UnloadSegment("Characters\init\" + fname);
}
}
In the case of the problem, fname is "TempQuestEnemy.c" and func = "CreateTempQuestEnemyCharacters". So it will try to call that function after it loads the .c file. But in that TempQuestEnemy.c file, there is no function in the script I have from you. It looks like this:
int CreateTempQuestEnemy(int n)
Notice that it is the wrong name, and also does not pass a reference type for &n, but rather an int n. It should look like this:
void CreateTempQuestEnemyCharacters(ref n)
What happens with that original script is nothing happens and an error is logged that it can't find function CreateTempQuestEnemyCharacters in TempQuestEnemy.c. That is not a porting problem and should not work no matter if it is Storm 2.0, Storm 2.8 or Maelstrom.
This PROGRAM folder is from original New Horizons mod for 2.0 engine. I compared it and it has 2.547 files, while the one I have now has 4.393. Is it possible that some files are obsolete?
https://mega.nz/file/9DQ0gZKa#mdfJ3ekLJuMaOYZkq5HTprotUmRwk3VZlC-aF2hLCtA