Check out this one.
https://mega.nz/file/gTBBFYCZ#r_spCsxVZWrF-SlKn_1E5F7RCe9XTXipuFGIvxJdbEU
It should boot up now. The reason it says 2018 is because all the newer updates in New Horizons are put up by a few modders on PA! From my personal experience, their tweaks actually brake the game and make it even more unstable. I have tested that on the original POTC game with 2.0 Storm engine. That's why I would prefer to stay with 2018 build for now. But it crashes for some reason and it doesn't even leave error logs. 90% of the scripts from PROGRAM folder are ported.
First, 99.9% of the SendMessage statements require the exact type/number of additional parameters, else they will crash the game, without warning or log message (some are more forgiving if the type is correct, but may have optional trailing parameters, but they are very few). It's always been that way and I have yet to implement a .log message or more graceful handling of that as it's not a priority for scripts that are accurate like the ones we currently have.
In Program\Characters\CharacterUtilite.c, line 4052, MSG_CHARACTER_SETBLADE has a problem. Change to:
SendMessage(chref, "llsfll", MSG_CHARACTER_SETBLADE, 0, modelName, liveTime, colors, colore);
Even after fixing, I can't run the game past this because I am missing a bunch of the newer Resources, so the start location fails to load some models for the default quest and it also looks like there are some script problems for things not defined, like SHIP_BATTLESHIP_FRANCE
Ok, so changing the code in CharacterUtilite.c now loads the scene, but after loading to shore, it crashes again. At least now I have log in error logs which says:
RUNTIME ERROR - file: sea_ai\AIShip.c; line: 189
Can't create class: Flg3
RUNTIME ERROR - file: sea_ai\AIShip.c; line: 196
Can't create class: Pnt3
RUNTIME ERROR - file: sea_ai\AIShip.c; line: 205
Can't create class: PFg2
RUNTIME ERROR - file: sea_ai\AIShip.c; line: 212
Can't create class: PPn2
RUNTIME ERROR - file: sea_ai\AIShip.c; line: 221
Can't create class: QFg2
RUNTIME ERROR - file: sea_ai\AIShip.c; line: 228
Can't create class: QPn2
RUNTIME ERROR - file: sea_ai\AIShip.c; line: 235
Can't create class: FFg3
When they made New Horizons, they copied the modules\rigging.dll a bunch of times, then used a HexEditor to change the class name inside the .dll binary file. As a favor to allow Maelstrom to possibly be used similarly, I added features to rigging that would emulate the same behavior, but it requires different scripting and also modification to rigging.ini; I am not going to hex-edit the .dll files like they did, but instead provide the functionality that they were trying to achieve, but in a more proper manner, through features inside the engine/modules.
Use a visual file difference tool (like WinMerge) to compare that AIShip.c to the modified one we supply. Also compare the RESOURCE\INI\rigging.ini the same way and make the same changes in our version to the New Horizons version.
There are also similar issues with the LogInterface, where the original engine only allowed one instance of it, but New Horizons copied the .dll and hex edited it. So I added a way to achieve that too. This is why you need to compare all files in two versions and find the changes needed to make it work for Maelstrom (both programs, INI files and in some cases RESOURCE files that need to be moved to different directories).
If they had one more programmer like you, they would've finished porting New Horizons long time ago. Instead, we independent enthusiats have to do it for them. I have used winmerge and replaced a few scripts with the AiShip.c that your provided with your ported New Horizons and now it goes past the Loading screen and the games starts fine. I have noticed though that it skips the video that loads when starting Free Play and Sea Hawk storyline about Oxbay being attacked. So it just skips it but it works. In your current port (from 2016) it shows the video. I will have to check that as well. Also I have no success in fixing the spyglass. When you press Ctrl key in first sail mode, nothing happens. I can see that the ispyglass.c file is there in Battleinteface folder, so it's not missing.
Here's the fixed AIShip.c file (but not completely checked with WinMerge):
https://mega.nz/file/BKwg1QiT#MqvbXa9Iv0xndj79akSbT3-cF3zmaRK5UfGokz4yvFs
You're doing well.
For the telescope, it looks like a parameter needs to be removed from both the function implementation in ispyglass.c for both void TelescopeInitParameters() and void setTelescopeInitParameters(aref arItmScope) and also remove the extra parameter from wherever it is called from, like CharacterUtilite.c setTelescopeInitParameters(&Telescope,arItm); and sea.c TelescopeInitParameters(&Telescope);
The following things are broken now:
telescope
Credits button in Main Menu does not show up credits video (on your 2016 build it shows up, so that's broken at the moment)
Starting a New Game with Nathaniel Hawk and Free Play game don't show initial video which is called Storm.wmv located in Resource\Videos (in your 2016 build this also works, so it's broken at the moment)
