I have already exported Sprite_UIPicture and Sprite_UICommand under the window.VS221.MenuUIPro namespace. This should be sufficient for you to implement the Dynamic Pictures compatibility on your end.
Viewing post in `Sprite_UIPicture` access
I think I can work with this, but I’m not sure why you tried to replicate the Game_Picture/Sprite_Picture API, i.e. the new
get _pictureName() { ... }
set _pictureName(value) {}
picture() {}
that you added to Sprite_UIPicture. These aren’t useful as extension points since they aren’t used internally by your plugin at all.
You also exposed the classes on window directly, which increases the risk of collisions with other plugins. (Letting third-party plugin devs replace classes entirely in not very helpful, as it makes for very brittle integrations that risk crashes as plugins are updated.)
I’ll probably postpone this for the time being, since you also started to mix in other features. I don’t think that’s the sort of clean single-purpose plugin I was looking for.
You're right. I haven't had the time to clear out the dead code yet, but I will clean it up later.
As for the extra features, I included them because I use this plugin for my own project as well. I don't have the time to create separate plugins, and since these features are somewhat related to the UI, I decided to just add them in.