thanks a lot again.
I'll try to fix as much as I can today.
this is the math for speed boost
completion_time *= 10 / (10 + total_speed_boost)
I did it so there wont be crazy speeds like 0.00001 with a lot of potions or items.
multiple potions are intentional because as you mentioned, you sacrifice inventory space for them.
That's how I thought you'd do the speed boost equation and I agree the logic makes sense.
The issue I'm pointing out is the scaling you're using for the things contributing to "total_speed_boost", vs how they're displayed in the game.
For example, MINING SPEED POTION's boost is displayed as "+275%" in game. I'm guessing that the value stored for that effect is "2.75", but in your equation you're using "10" to represent "100%". That means "2.75" is actually contributing "+27.5%" relative to 10, instead of "275%", which gives the value the results I'm seeing in-game for mining iron ore:
completion_time *= 10 / (10 + total_speed_boost) completion_time = 5 seconds total_speed_boost = 2.75 5 seconds * 10 / (10 + 2.75) = 3.9216 seconds
(and 3.9216/5 = 1.275, or "127.5%")
So either the effects in-game aren't showing properly (gold cooking pot should show +20% instead of +200%), or you need to adjust your equation or the values (probably just by changing the "10"s in the equation to "1"s)
Added note: I didn't get far enough to be able to check if these were giving their items properly or how the items worked: red and gold mining locations, mythril bar smelting, great woods, cotton, level 50 gathering, last 2 potions, last 2 enemies. Might want to double check to make sure they give items, as well.
If you can't fix everything quickly, don't beat yourself up about it!