Post by dranorter in Procgen Tarot comments

Viewing post in Procgen Tarot comments

There appears to be a bug - sometimes one or two areas on a card don't get colored in. I was able to fix this by commenting out

if(duplicate) { return null; }

inside the register(shape) function in Painter. So the problem is with how it detects duplicates.

dranorter3 years ago(+1)

OK, I've fixed the bug 3 different ways and I think what's happening is that occasionally one region entirely contains another. The function register(shape) only checks whether an existing region has points outside the shape, not whether the new shape has points outside an existing region. Comparing the sizes of the two regions can show them to be not duplicates (and skips a lot of comparisons), or the comparison can be done symmetrically to notice that shape contains points outside the existing region.

itch.io

Viewing post in Procgen Tarot comments