Post by CloverCDX in Need Support? Post here!

Controller Support Expansion for Ren'Py » Community

Viewing post in Need Support? Post here!

I have grid with one row and eight columns (technically six, but with an extra two on the left and right respectively to create null space to keep all the items centered), and within this grid are imagebuttons. each opens a screen to display some options, but if that screen is closed, the viewport scrolls itself by a small amount? this does not happen with an hbox in place of the grid, however the grid is necessary for a certain effect unrelated to this (done via atl) to function correctly. is there something i'm doing wrong? below is my code for review.

default current_chapter = 1
default ch1_selected = False
default ch2_selected = False
default ch3_selected = False
default ch4_selected = False
default ch5_selected = False
default ch6_selected = False
screen chapter_select():
    tag menu
    on "show":
        action [SetVariable("ch1_selected", False), 
                SetVariable("ch2_selected", False), 
                SetVariable("ch3_selected", False), 
                SetVariable("ch4_selected", False), 
                SetVariable("ch5_selected", False), 
                SetVariable("ch6_selected", False)]
    add "gui/bgs/genericbg.png"
    use game_menu(_("CHAPTER SELECT")):
        side 'c':
            pos (-325, -100) xysize (1920, 1080)
            controller_viewport:
                mousewheel True draggable renpy.variant("touch")
                id "viewport_chapter_select" hscroll_style "center"
                scroll_delay (0.5, 0.0)
                trap_focus ("up", "down", "left", "right")
                scroll_warper "easein"
                grid 8 1:
                    spacing 400
                    add "gui/chapter_select/card_empty.png" xalign 0.5 yalign 0.45
                    imagebutton:
                        xalign 0.5
                        yalign 0.45
                        if current_chapter == 1:
                            default_focus True
                        auto "gui/chapter_select/card_ch1_%s.png"
                        action [SetVariable("ch1_selected", True), Show("chapter_confirm")]
                        at (cardfliphide if ch1_selected else cardflipshow)
                        hovered SetVariable("current_chapter", 1)
                        hover_sound "sfx/menu_hover.ogg"
                        activate_sound "sfx/menu_select.ogg"
                    imagebutton:
                        xalign 0.5
                        yalign 0.45
                        if persistent.ch2_unlocked == True:
                            if current_chapter == 2:
                                default_focus True
                            auto "gui/chapter_select/card_ch2_%s.png"
                            action [SetVariable("ch2_selected", True), Show("chapter_confirm")]
                        else:
                            idle "gui/chapter_select/locked.png"
                            action NullAction()
                        at (cardfliphide if ch2_selected else cardflipshow)
                        hovered SetVariable("current_chapter", 2)
                        hover_sound "sfx/menu_hover.ogg"
                        activate_sound "sfx/menu_select.ogg"
                    imagebutton:
                        xalign 0.5
                        yalign 0.45
                        if persistent.ch3_unlocked == True:
                            if current_chapter == 3:
                                default_focus True
                            auto "gui/chapter_select/card_ch3_%s.png"
                            action [SetVariable("ch3_selected", True), Show("chapter_confirm")]
                        else:
                            idle "gui/chapter_select/locked.png"
                            action NullAction()
                        at (cardfliphide if ch3_selected else cardflipshow)
                        hovered SetVariable("current_chapter", 3)
                        hover_sound "sfx/menu_hover.ogg"
                        activate_sound "sfx/menu_select.ogg"
                    imagebutton:
                        xalign 0.5
                        yalign 0.45
                        if persistent.ch4_unlocked == True:
                            if current_chapter == 4:
                                default_focus True
                            auto "gui/chapter_select/card_ch4_%s.png"
                            action [SetVariable("ch4_selected", True), Show("chapter_confirm")]
                        else:
                            idle "gui/chapter_select/locked.png"
                            action NullAction()
                        at (cardfliphide if ch4_selected else cardflipshow)
                        hovered SetVariable("current_chapter", 4)
                        hover_sound "sfx/menu_hover.ogg"
                        activate_sound "sfx/menu_select.ogg"
                    imagebutton:
                        xalign 0.5
                        yalign 0.45
                        if persistent.ch5_unlocked == True:
                            if current_chapter == 5:
                                default_focus True
                            auto "gui/chapter_select/card_ch5_%s.png"
                            action [SetVariable("ch5_selected", True), Show("chapter_confirm")]
                        else:
                            idle "gui/chapter_select/locked.png"
                            action NullAction()
                        at (cardfliphide if ch5_selected else cardflipshow)
                        hovered SetVariable("current_chapter", 5)
                        hover_sound "sfx/menu_hover.ogg"
                        activate_sound "sfx/menu_select.ogg"
                    imagebutton:
                        xalign 0.5
                        yalign 0.45
                        if persistent.ch6_unlocked == True:
                            if current_chapter == 6:
                                default_focus True
                            auto "gui/chapter_select/card_ch6_%s.png"
                            action [SetVariable("ch6_selected", True), Show("chapter_confirm")]
                        else:
                            idle "gui/chapter_select/locked.png"
                            action NullAction()
                        at (cardfliphide if ch6_selected else cardflipshow)
                        hovered SetVariable("current_chapter", 6)
                        hover_sound "sfx/menu_hover.ogg"
                        activate_sound "sfx/menu_select.ogg"
                    add "gui/chapter_select/card_empty.png" xalign 0.5 yalign 0.45
screen chapter_confirm():
    modal True
    frame:
        background None
        add "gui/chapter_select/card_back.png" xalign 0.501 yalign 0.498
        align (0.5, 0.5)
        at cardflipcombined
        vbox:
            xalign 0.5
            yalign 0.5
            spacing 10
            if current_chapter == 1:
                text "Would you like to play\nChapter One?" textalign 0.5 style "btn_generic" color "#fff"
            if current_chapter == 2:
                text "Would you like to play\nChapter Two?" textalign 0.5 style "btn_generic" color "#fff"
            if current_chapter == 3:
                text "Would you like to play\nChapter Three?" textalign 0.5 style "btn_generic" color "#fff"
            if current_chapter == 4:
                text "Would you like to play\nChapter Four?" textalign 0.5 style "btn_generic" color "#fff"
            if current_chapter == 5:
                text "Would you like to play\nChapter Five?" textalign 0.5 style "btn_generic" color "#fff"
            if current_chapter == 6:
                text "Would you like to play\nChapter Six?" textalign 0.5 style "btn_generic" color "#fff"
            textbutton _("Yes"):
                at btn_grow
                default_focus True
                xalign 0.5
                text_style "btn_generic"
                if current_chapter == 1:
                    action Start("ch1_start")
                if current_chapter == 2:
                    action Start("ch2_start")
                if current_chapter == 3:
                    action Start("ch3_start")
                if current_chapter == 4:
                    action Start("ch4_start")
                if current_chapter == 5:
                    action Start("ch5_start")
                if current_chapter == 6:
                    action Start("ch6_start")
            textbutton _("No"):
                at btn_grow
                xalign 0.5
                text_style "btn_generic"
                action [SetVariable("ch1_selected", False), SetVariable("ch2_selected", False), SetVariable("ch3_selected", False), SetVariable("ch4_selected", False), SetVariable("ch5_selected", False), SetVariable("ch6_selected", False), Hide("chapter_confirm")]
        key "rollback" action [SetVariable("ch1_selected", False), SetVariable("ch2_selected", False), SetVariable("ch3_selected", False), SetVariable("ch4_selected", False), SetVariable("ch5_selected", False), SetVariable("ch6_selected", False), Hide("chapter_confirm")]

Feniks15 days ago

Is it just that the viewport is centering on the button when it's re-selected? Obviously without a visual it's hard to tell; one thing of note is that all grid squares will have the exact same size, which isn't true of hbox, which may be a reason for the discrepancy in behaviour.

CloverCDX13 days ago

i dont believe so because the button is offcenter when its reselected. i can try to record a video to show the issue shortly

Feniks13 days ago

Ah, you're using a transform that is changing the size of the displayable. Can you try putting it inside a fixed with a set size (the maximum size of the card when it's not being flipped)?

CloverCDX12 days ago

just tried this, but it only seems to make the issue worse. i assume you meant apply a fixed to all entries in the grid, so i did that, however that seems to just ignore the center alignment entirely bc now everything is aligned to the left and still does that extra scroll thing after closing out the menu.

Feniks12 days ago

What exactly does your code look like?

CloverCDX10 days ago

Same as what i sent before, but each of the imagebuttons now has a fixed: as a wrapper with the xysize set to the full image scale

Feniks10 days ago

Show the actual code, please.

CloverCDX9 days ago

default current_chapter = 1
default ch1_selected = False
default ch2_selected = False
default ch3_selected = False
default ch4_selected = False
default ch5_selected = False
default ch6_selected = False
screen chapter_select():
    tag menu
    on "show":
        action [SetVariable("ch1_selected", False), 
                SetVariable("ch2_selected", False), 
                SetVariable("ch3_selected", False), 
                SetVariable("ch4_selected", False), 
                SetVariable("ch5_selected", False), 
                SetVariable("ch6_selected", False)]
    add "gui/bgs/genericbg.png"
    use game_menu(_("CHAPTER SELECT")):
        side 'c':
            pos (-325, -100) xysize (1920, 1080)
            controller_viewport:
                mousewheel True draggable renpy.variant("touch")
                id "viewport_chapter_select" hscroll_style "center"
                scroll_delay (0.5, 0.0)
                trap_focus ("up", "down", "left", "right")
                scroll_warper "easein"
                grid 8 1:
                    spacing 400
                    add "gui/chapter_select/card_empty.png" xalign 0.5 yalign 0.45
                    fixed:
                        xysize(518, 778)
                        imagebutton:
                            xalign 0.5
                            yalign 0.45
                            if current_chapter == 1:
                                default_focus True
                            auto "gui/chapter_select/card_ch1_%s.png"
                            action [SetVariable("ch1_selected", True), Show("chapter_confirm")]
                            at (cardfliphide if ch1_selected else cardflipshow)
                            hover_sound "sfx/menu_hover.ogg"
                            activate_sound "sfx/menu_select.ogg"
                    fixed:
                        xysize(518, 778)
                        imagebutton:
                            xalign 0.5
                            yalign 0.45
                            if persistent.ch2_unlocked == True:
                                if current_chapter == 2:
                                    default_focus True
                                auto "gui/chapter_select/card_ch2_%s.png"
                                action [SetVariable("ch2_selected", True), Show("chapter_confirm")]
                            else:
                                idle "gui/chapter_select/locked.png"
                                action NullAction()
                            at (cardfliphide if ch2_selected else cardflipshow)
                            hover_sound "sfx/menu_hover.ogg"
                            activate_sound "sfx/menu_select.ogg"
                    fixed:
                        xysize(518, 778)
                        imagebutton:
                            xalign 0.5
                            yalign 0.45
                            if persistent.ch3_unlocked == True:
                                if current_chapter == 3:
                                    default_focus True
                                auto "gui/chapter_select/card_ch3_%s.png"
                                action [SetVariable("ch3_selected", True), Show("chapter_confirm")]
                            else:
                                idle "gui/chapter_select/locked.png"
                                action NullAction()
                            at (cardfliphide if ch3_selected else cardflipshow)
                            hover_sound "sfx/menu_hover.ogg"
                            activate_sound "sfx/menu_select.ogg"
                    fixed:
                        xysize(518, 778)
                        imagebutton:
                            xalign 0.5
                            yalign 0.45
                            if persistent.ch4_unlocked == True:
                                if current_chapter == 4:
                                    default_focus True
                                auto "gui/chapter_select/card_ch4_%s.png"
                                action [SetVariable("ch4_selected", True), Show("chapter_confirm")]
                            else:
                                idle "gui/chapter_select/locked.png"
                                action NullAction()
                            at (cardfliphide if ch4_selected else cardflipshow)
                            hover_sound "sfx/menu_hover.ogg"
                            activate_sound "sfx/menu_select.ogg"
                    fixed:
                        xysize(518, 778)
                        imagebutton:
                            xalign 0.5
                            yalign 0.45
                            if persistent.ch5_unlocked == True:
                                if current_chapter == 5:
                                    default_focus True
                                auto "gui/chapter_select/card_ch5_%s.png"
                                action [SetVariable("ch5_selected", True), Show("chapter_confirm")]
                            else:
                                idle "gui/chapter_select/locked.png"
                                action NullAction()
                            at (cardfliphide if ch5_selected else cardflipshow)
                            hover_sound "sfx/menu_hover.ogg"
                            activate_sound "sfx/menu_select.ogg"
                    fixed:
                        xysize(518, 778)
                        imagebutton:
                            xalign 0.5
                            yalign 0.45
                            if persistent.ch6_unlocked == True:
                                if current_chapter == 6:
                                    default_focus True
                                auto "gui/chapter_select/card_ch6_%s.png"
                                action [SetVariable("ch6_selected", True), Show("chapter_confirm")]
                            else:
                                idle "gui/chapter_select/locked.png"
                                action NullAction()
                            at (cardfliphide if ch6_selected else cardflipshow)
                            hover_sound "sfx/menu_hover.ogg"
                            activate_sound "sfx/menu_select.ogg"
                    add "gui/chapter_select/card_empty.png" xalign 0.5 yalign 0.45
    
screen chapter_confirm():
    modal True
    frame:
        background None
        add "gui/chapter_select/card_back.png" xalign 0.501 yalign 0.498
        align (0.5, 0.5)
        at cardflipcombined
        vbox:
            xalign 0.5
            yalign 0.5
            spacing 10
            if current_chapter == 1:
                text "Would you like to play\nChapter One?" textalign 0.5 style "btn_generic" color "#fff"
            if current_chapter == 2:
                text "Would you like to play\nChapter Two?" textalign 0.5 style "btn_generic" color "#fff"
            if current_chapter == 3:
                text "Would you like to play\nChapter Three?" textalign 0.5 style "btn_generic" color "#fff"
            if current_chapter == 4:
                text "Would you like to play\nChapter Four?" textalign 0.5 style "btn_generic" color "#fff"
            if current_chapter == 5:
                text "Would you like to play\nChapter Five?" textalign 0.5 style "btn_generic" color "#fff"
            if current_chapter == 6:
                text "Would you like to play\nChapter Six?" textalign 0.5 style "btn_generic" color "#fff"
            textbutton _("Yes"):
                at btn_grow
                default_focus True
                xalign 0.5
                text_style "btn_generic"
                if current_chapter == 1:
                    action Start("ch1_start")
                if current_chapter == 2:
                    action Start("ch2_start")
                if current_chapter == 3:
                    action Start("ch3_start")
                if current_chapter == 4:
                    action Start("ch4_start")
                if current_chapter == 5:
                    action Start("ch5_start")
                if current_chapter == 6:
                    action Start("ch6_start")
            textbutton _("No"):
                at btn_grow
                xalign 0.5
                text_style "btn_generic"
                action [SetVariable("ch1_selected", False), SetVariable("ch2_selected", False), SetVariable("ch3_selected", False), SetVariable("ch4_selected", False), SetVariable("ch5_selected", False), SetVariable("ch6_selected", False), Hide("chapter_confirm")]
        key "rollback" action [SetVariable("ch1_selected", False), SetVariable("ch2_selected", False), SetVariable("ch3_selected", False), SetVariable("ch4_selected", False), SetVariable("ch5_selected", False), SetVariable("ch6_selected", False), Hide("chapter_confirm")]

Feniks9 days ago

What do your ATL transforms look like?

To be honest, I'm not sure this is a good use case for the controller viewport, or even a viewport at all. Given the animations you want to do, I'd probably just manually assign left/right to swap whatever card is in the center, and use ATL animations to move them to the right location. The cards wouldn't even need to be buttons; you can just have a variable track which one is selected and perform an action accordingly when the button_select action is performed.

View more in thread

CloverCDX13 days ago

https://streamable.com/o3zub2

heres a video of the issue

itch.io

Viewing post in Need Support? Post here!