Post by AricTriton in Aric's Expansion Rebred

Viewing post in Aric's Expansion Rebred

Love what I’m seeing so far and appreciate the write-up. A couple of notes from the systems you explained so far. I’ll dig into the code after work to see more precise details.

Ovulation System - You mentioned precise variables for that system. The issue I can foresee is that it may conflict with edited values if the player changes the pregnancy duration via the Headgirl.

I would recommend changing them from Ovulating 5/8 and resting 15 to Ovulating duration = globals.variables.pregduration * .25 or *30 and resting globals.variables.pregduration * .75 or *.70, whatever your monthly percentage is. If you’d prefer players to have greater control and flexibility, you could also just create a variable in expansion.gd > settings called cyclelength to have the percentages based on, then one of us can tie it into the existing pregnancy length dialogue system to be able to shorten or lengthen durations fluidly.

Secondly, regarding existing game support from the person edit that should be easy to add. Create a function that checks if a person has the dictionary value and adds it if not. Either toss that into backwards compatibility or just call your function from it. There should be examples in the expandPerson function to show how it can work

deviate3 years ago (1 edit)

I really like the variable to modify the on/off cycle lengths so I’ll implement that. I hesitate to use a percent of pregduration because I sometimes set that 90 or 180 days to make the game a bit more realistic so the on/off cycle would be way out of wack in such cases (same thing if the pregduration is really short).

You will notice when you dig into the code I tried to respect all of your expansion’s flags. I wanted the system to feel like a fully integrated part of your mod and not just a bolt-on afterthought. If you notice any I missed please let me know.

As for the person file I did not know that. I’ll read through the code tonight.

One question for you, what is the purpose of the perfectview variable? When displaying metric data I wanted to require a nurse for some information but also wanted to respect any mod variables which should override that requirement. But it looks like the perfectview variable is always set to true.

AricTriton3 years ago (2 edits)

Perfect Info is a Boolean that will unlock the ability to always see if someone is pregnant or lactating even before they tell you. Otherwise it will not show in statistics until they have told you that they are pregnant/lactating.

It was intended as a debug feature but is also a way for users to circumvent the whole “slave keeping secrets” part of the mod.

Edit: The one thing to keep in mind is that the backwards compatibility formula I’ve been using really works best when checking for values within an existing dictionary in that save game. Otherwise you’ll have to add the entire new dictionary to the person class. That’s a big part of why I implemented the npcexpanded dictionary early on, as that can be an easy catch-all for any new variables added to the person class to be checked with if !person.npcexpanded.has(‘example’):

itch.io

Viewing post in Aric's Expansion Rebred