Post by Keri in MariaEngine 64 + Open World Edition comments

MariaEngine 64 + Open World Edition » Comments

Viewing post in MariaEngine 64 + Open World Edition comments

Uh oh. I've encountered two more runtime errors in the Legacy version's stage editor. You might need to update it again...

This first one happens when clicking on the "Enemies" tab in the editor (I'm pretty sure this error is the same one as before, with the minus signs preceding scripts so it's an easy fix)

___________________________________________

############################################################################################

ERROR in action number 1

of Mouse Event for Glob Left Pressed for object obj_editoroverlay:

DoNeg :1: illegal reference use

at gml_Object_obj_editoroverlay_Mouse_53 (line 20) - script_execute(-bev)

############################################################################################

gml_Object_obj_editoroverlay_Mouse_53 (line 20)

----

And then this second crash happens when placing a "Waterfall" object under the "Misc Props" tab in the editor:

___________________________________________

############################################################################################

ERROR in action number 1

of Alarm Event for alarm 0 for object obj_waterfall:

unable to convert string "" to number

at gml_Object_obj_waterfall_Alarm_0 (line 4) - terrain_height = max(terrain_height,real(my_creation_arg))

############################################################################################

gml_Object_obj_waterfall_Alarm_0 (line 4)

Yal94 days ago(+1)

I'll get to it right away!

Yal94 days ago(+1)

The fix should be available now :)

Keri89 days ago

GMSMariaEngine64PathOops

In the Open World version's Stage Editor, I noticed that if you save a level with a footpath, and then import that same level with Prefab, the footpath isn't being spawned again into the correct place. Its position keeps randomly being moved along the Y/Z axis. Is there any way this can be fixed?

Yal88 days ago (1 edit) (+1)

I did some test with both prefabs and copypastes, and it works for me (including rotations, and copying a footpath + moving along an axis causing the copy to be parallel to the original), but I did notice a bug - if you don't press "enter" to finalize the path data before saving a prefab file it gets saved in an incomplete state. This might be what's happening here?

The only other things I can think of is if the origin coordinate calculation gets messed up when you load the prefab with the marker size larger than 1x1x1 or if there was some funky interaction with you having something in the copypaste buffer already when loading a prefab - does it behave as expected if you press "alt" to quick-reset the cursor before loading the prefab?

Keri87 days ago (2 edits)

Yes I did make sure to finalize the path data before saving the prefab (otherwise the path objects don't get exported at all!)

When I press "alt" to reset the cursor, that doesn't do anything because when the prefab is loaded the cursor automatically gets rescaled to the size of the prefab. So somewhere in the prefab code the origin coordinate calculation for footpath objects is messed up. Copy/pastes seem to be working fine though, so I'm not sure what's causing this

Yal87 days ago(+1)

Yeah, and the prefab system uses the copy/paste system internally so they should behave the same...

The only thing I can think of that could differ is how editor_arrayify_patternobject subtracts the editormarker's position from each point in the path when copying (to get relative distances that can be rotated), does that somehow act differently when loading a prefab because the marker could be anywhere perhaps? (instead of a place that includes the path's origin, which is guaranteed when copypasting)

Keri86 days ago

Took a good look in the code and I'm pretty sure the culprit here is within the function "load_level_editor_prefab()".

If I comment out the section "Normalize stuff around (0,0,0)", the paths are now generated in the correct place alongside in relation to the rest of the geometry.

Granted, now the cursor marker's position and size is a bit wrong, but I think that should be an easy fix... 🤔

Yal85 days ago(+1)

Ah... that code only adjusts the object's regular coordinates and not the individual points of the footpath, so they're desynchronized. I wonder if it messes with how the new points are calculated when the rotations are applied? editor_unarrayify_patternobject doesn't actually use the object coordinates at all (only the individual points, which are absolute values relative to the editormarker and thus ALSO not affected by the footpath object's coordinates) so I don't see how this would affect it, but I also haven't touched this stuff since march 2023 so my memory is quite fuzzy.

Either way, I think the better way to fix it would be to, after updating the coordinates, check if oldcoords[3] is obj_footpath, and if so oldcoords[14] is the number of points; 15,16,17 is the first point's x,y,z coordinates and so on - you'd go through each such trio of points in ret_pattern[c] (which is the updated version of oldcoords) and subtracting xmin, ymin and zmin.

Keri85 days ago (2 edits)

Not 100% sure if I did this the right way based on what you said, but this ended up fixing it! Edit: removed the image because that code was wrong... but I adjusted it so that now the prefab paths are in the correct spot and the cursor marker retains the correct size and position. Thanks for the help!

Yal84 days ago

...I have no idea how it fixed the problem because now you just replace the origin point with every path point and only keep the last one's value, but if that somehow solves the problem that's ultimately all that matters :P

View more in thread

itch.io

Viewing post in MariaEngine 64 + Open World Edition comments