A lot of the issues I complained about were fixed in the last update, thank you! I managed to actually play video this time.
But there are few comments I'd like to make:
- A lot of printing happens even when the debugging option is off. It probably shouldn't print anything. For example
"GoZenAudio: Stream duration: 223.
GoZenAudio: Total size: 39374848."
- I had an issue in my project code where it would call «set_video_path()» multiple times. This made the plugin cause a crash. Probably trying to load a video while not finished with the last one. You should probably throw an error or ignore further calls until the current loading is ready.
- The "playback_ready" signal seems to not do anything. It is called when the player is first ready, but even if a video path is set in the inspector, variables like «_resolution» and the «get_video_frame_count()» function return zero. Calling «set_video_path()» will never emit this signal again.
- The video seeking functions, including signals for change of frame are working under frame numbers, but in most cases, video timestamps are more useful. You should have helper functions that take or return values in seconds, or at least a function to convert between frame count and seconds of video. It would need to take into account frame rate and such.
- I was interested in getting video dimensions in my project. But it would also be cool to have a function that returns a given frame of video given the frame number. Then we may use the Image class for further processing or inspection.
- I find it useful that the video frame scales with the space available to it, but could you have an option to constrain to the video's nominal resolution without stretching, like the native player does?