Post by Noctellion in MV - Cosmetic Equipment comments

Viewing post in MV - Cosmetic Equipment comments

Hey Ramza, I'm having an issue after installing this plugin after trying to start a new game about a maximum call stack:

It goes away after toggling the plugin off, haven't seen it before. Let me know if you need more info. thanks.

Edit: So, after toggling a hundred plugins or so, I've finally narrowed it down to Yanfly's Party System. The error will only come up if the cosmetic set parameter has something in it, if the plugin is enabled but otherwise "empty" then it won't crash. Tested with a New Project to be certain:

Edit 2: I loaded it into a new project without Party System. Seems to launch there with no issue, but I'm not able to get the priority name to change :

The armor appears to change our boy Lucius' images and such without any trouble, but if I've set the parameters up correctly, his name should be Jim. Thanks again :)

Ramza5 years ago (1 edit)

Greetings.

I corrected the first problem. I'm not too sure on what the exact cause of the problem was, normally that error happens if a function is aliased incorrectly and ends up calling itself multiple times. While this didn't seem to be the case, it appears as though YEP_PartySystem and my plugin interacted in a way that caused the refresh function to be called enough times to crash. I aliased a different function from which to call my refresh on game start, which no longer causes issues.

As for the second issue, your setup appears correct. I'm not sure why Lucius name isn't changing. However, while looking into this, I did notice a problem where an actor who was using a cosmetic set that did not set a priority name would receive the name 'null' instead, so I fixed that in this version as well. Maybe see if the new version corrects this problem?

Noctellion5 years ago

Sup Ramza, hope your weekend is going well :)

It launches smoothly now, thank you. So, I was trying to get the name change to work, still wasn't changing even though the sprites and faces were. I even tried using the Cosmetic Equipment demo to no avail. Then I noticed in your screen you were using the Angel set. I was working with Harold's Wolf set. THAT was the issue lol. For some reason, the first Cosmetic Set in the Structure List won't change the priority name. But the second will with no apparent problem:

So far I've been able to get by in my project by making a dummy set in the first slot, and just not using it. Also, in the first set, the "ActorSprites" parameter in the structure list can't be empty or the second won't work either. The values don't have to be filled with anything, but the plain text does have to be there, if I'm explaining that right:

Sorry to keep bothering you T_T

Ramza5 years ago

No bother at all, in fact, I appreciate your in-depth testing, it makes finding the problem easier.

I tracked this one down to the fact that I used an if statement that checked for a 'falsy' statement, instead of for if a value was undefined. The normal if check (if (VARIABLENAME){ do stuff }) will return false if VARIABLENAME doesn't exist. Unfortunately, it will also return false if it has the number value 0, as well. I was using the above to check if a priority name had been defined for the current set, but it never checked against set number 0 (the first one) because if the value was zero, it was treating it as if it had not been defined.

I also corrected the other problem you found. Although you didn't mention specifically, starting the game when the ActorSprite value of any set is completely blank will cause the plugin to throw an error and not load, but won't cause the engine to crash, instead allowing you to play the project with all cosmetic set effects disabled. This is because the default value is supposed to be an empty array. If the value is instead blank, the plugin fails to parse it's data entirely, throws an error and fails to load. If the data is a blank array, it can parse it as nothing, and move on.

To correct that, I changed the plugin parameter to be [] by default, instead of blank. So if you create a new set that contains no actor specific sprites, and never touch the ActorSprites parameter, it won't remain blank and crash the project.

These fixes are already uploaded. I added a revision to v1.21, and you can download it at the same link as before.

-Ramza

Noctellion5 years ago

It works perfectly! Thanks for everything my dude. You really went out of your way.

itch.io

Viewing post in MV - Cosmetic Equipment comments