Post by mattmirrorfish in roomchain generator seems to be broken (mod edit: fixed!)

Strata Easy 2D Level Generator For Unity » Community

Viewing post in roomchain generator seems to be broken (mod edit: fixed!)

Quick update, I think the issue was that for some reason I failed to call ClearLevel() during the loop in BuildLevel(), leading to old data on subsequent loops. I think this was an attempt to optimize gone wrong. Could you please try adding a call to ClearLevel() to the beginning of the for loop in BuildLevel (around line 203 of BoardGenerator) and let me know if that solves this issue for you? It looks good on my end, if it works for you I'll ship the fix.

Thanks again and sorry I missed the earlier response. I'm new to using Itch for this purpose.

Best,

Matt

r6185 years ago

Hi, don't worry, I'm prototyping other stuff, not sure what (and if) generator should be the best yet

Yes, I've tried to move the whole setup before the loop in BoardGenerator into separate function and called that inside the loop before RunGenerators() - this results in non consistent state when generation fails ( generationSucceeded == false ) such that the minimal number of rooms is not reached and generated tilemap layout does not correspond to generated board data ( I have player placed inside first room after generation which is off the rooms chain in that case ) - probably something's not cleared enough in next iteration, but I did not investigate further yet

(there's plenty of space to run w 6x6 tiles and 102x102 tilemap, I've since deleted test package from OP, but I'll leave it here now: https://www.dropbox.com/s/tlp7sklzcu6i6fe/STroomchain.unitypackage?dl=0 (few SOs + scene))

I haven't tried other generators such as PlatformerRoomChain - I wanted very simple setup first with short (5-20), one-way non branching paths

it works neatly otherwise though :-)

Cheers!

mattmirrorfish5 years ago

Hmm so even calling ClearLevel the state is not reset? That's weird. There may be some parameter I'm failing to reset. For additional clarity, are you doing this in Play mode at Runtime or in Edit mode or both? Thanks for your patience, I'll take a look at your repro case and get back to you.

Honestly I probably should just move the state-ful stuff out of the BoardGenerator and into a function like almost everything else. Gonna have a think about it.

best,

Matt

r6185 years ago (1 edit)

i was just restarting play mode when it failed to produce chain on the first try, this was the same when generating in edit mode [clear&generate button]

when it failed the displayed chain was very short: 1- 3 rooms max - this seems to be correct though since there _are_ rooms w one entrance/exit only and requested minimum was 5

(as a sidenote: the condition for picking the next room should be probably more advanced and not entirely random if room template with more exits exists and end (edit: minimum rooms) was not reached - to not run in these premature dead ends; - but moreover there's no guarantee that the generation has successfully finished currently - I think you're safe to loop/yield until it is instead of hard limit though :-), but note that I'm totally fine with current state and can check result in user code if necessary)

'400' is enough for everybody, until a kitten is burnt ^_^

Cheers!

mattmirrorfish5 years ago

I just shipped an update (1.1) that replaces RoomChain with RoomSequence, which so far is much more robust. Also added RoomTiler which is sort of Wang tile inspired and spreads out along any open exit, as opposed to generating a linear sequence. If you have a chance to try it out I'd love to hear further feedback. Details here:

https://itch.io/t/298310/strata-11-is-out

Thanks!