Yep, it just rounds down to the nearest sample. That was my first implementation because I didn't yet know proper sampling was necessary :D I decided to keep it around because the gritty sound is surprisingly pleasant.
Honestly, that's great that you did keep it around. One of my most favorite features in samplers in general. So, great.
After trying this sampler, it does a lot of stuff just... great. I did have a few issues with glitchy audio in reaper, but I think it was just reaper having a hissy fit this day, so I think this can safely be ignored.
It really is a fully featured sampler, and workflow is mostly great. There were a few issues about the "sample bounds" being out of bounds when I zoomed in too much, I also accidentally recorded in stereo one time, and I do not see a sample trimming option which could be really nice to have.
Only a few other things I'd suggest to consider is supports for formats like ADPCM / mp3 / opus or others, and looking into low-quality linear interpolation (usually softer variant), and uh, maybe a way to save the presets as files? I haven't discovered this feature yet, if there is one. I've heard WAV format has great options for loop points baked in the format itself, though.
Also that reverb is definitely opinionated hahaha.
But yeah, it passed my song test. I'll keep using it in my future music, methinks. Unless I stumble upon a major dealbreaker (which I did not have so far, THANKFULLY). Have my "Best used with 8 bit wav" badge, iunno x3.
Thank you for the detailed feedback! Some thoughts:
- If you use the pin button (the bottom right of the waveform editor), you can stick the sample bounds to the visible window as you zoom in and out.
- It should be able to support mp3 on Linux, it might be as simple as an additional build flag and if so it'll be updated later today.
- I decided to delegate preset files to the host DAWs. The downside is preset compatibility between DAWs ofc.
- The format encoding/decoding is done through JUCE right now. More advanced WAV features would require some investigation into open-source options, so probably will not happen here.