The Leadership skill only seems to affect the unit that has it. My Veteran War Trolls with a Leadership +1 hero have 9 attack dice, and should have 10; 8 base + 1 from their level +1 from Leadership.
The hero has reached Commander level, but only due to Warlord. This may be a factor.