Did a complete purge of everything in adddata/roaming/strive including saves as well as re-installing seemed to work
I haven't tested it with 0.5.19 yet. Unfortunately the mod is probably fairly version specific if they're going to keep changing the code the mod applies to.
Edit: Just downloaded 0.5.19, applied the mod, no unexpected errors seen. Ran game again, did a quickstart, starting slave got a random portrait as expected, and random portrait button works. Same with slaves at slave trader.
Will need more information to know what's going wrong for you. Are you starting a new game to test this? Are you applying any other mods? What errors show up on the console? (there's always some that aren't actually a problem, but some might indicate what's going wrong). You can run the game from a command prompt and then the errors persist after the game closes.
Yeah unfortunately the game doesn't do anything special when making a new slave that is the main character so i can't skip the random portrait generation for that. I could insert clearing the full body image to the game's code for the start. Forgot about this as i manually edited my save to remove the full body image from it. I kind of want to wait and see how they're maybe going to tweak some of this in the near future.
https://itch.io/t/292969/bug-0519a-regex-for-variables-broken
You can use the modpanel.gd i linked to on pastebin from there if you want to use 0.5.19a, would need to replace it in both files and backup folders, otherwise changes will be lost after applying, making next apply also break. Hopefully fix is put into a 0.5.19b soon.
1. maunualy delete or just remove from mod folder
2. do one for all mod files the backup folder is in the game folder delete it.
3. re-install game (sometimes you will need a clean install which means deleting the old one or using a different folder)
4. start game ( this will create a new back up folder) then exit once your sure it works
5. put Mods back
6. restart then activate mod(s) and it should workk fine until the next update
This is what the game intends for you to be able to do:
1. Run game
2. Go to Mods
3. Click "reset"
4. Run game again, and should be back to stock.
Problem is some versions corrupted the backups folders. While in other situations, if the current files are corrupt, then you can't open the mods dialog, or use the reset button anyways. You can manually delete the files folder and replace it with a copy of the backup folder in the game folder, but the backup folder may be suspect. Thus best bet is to wipe the game folder and extract it again. Or extract it to some new location and use that.
0. Optional: Delete and re-extract mod, to ensure it's not been corrupted.
1. Delete and re-extract game
2. Run game, go to Mods, and apply
3. Run game again, mod should work.
Step 0 is maybe needed if you edited the mod in some broken way.
So. I figured out the problem.
You can't put the mod on a version of Strive installed on a hard drive that has admin permission required to make changes. (This is often the default for C drive.)
I recently moved Strive to C, (which is my SSD) for faster loading. However, windows was giving me shit, asking for permission for everything, and being unable to make shortcuts for some insipid reason. Checking the debug log, I saw the mod kept trying to make folders on the C drive, but failing. So, I tried moving the modded-strive back to my normal drive, and now the mod works again.
TLDR; mod only works if admin permission is granted by default.
When you replaced with v1.0 (which I hope you did), did you extract it fresh, or did you just extract it over top the old one? If you didn't extract it fresh to the mods folder (delete the old one first), then yeah that still wouldn't work, the v1.0 removes a file, if you just extract over you'd change basically nothing.
So, I think I found a bug. This is inside the 'pick portrait' button in game. When I enter a search term, say, 'titsb', I get pretty good filtered results. However, every 20th or so entry has about ten images superimposed on one another. I think they all fit the search results, but it's hard to tell with the text overlapping itself so much.
I'm not sure how provide a screenshot because my printscreen key doesn't work for this sub menu (it just records the main mansion menu).
Also, sometimes images or text will clip off the right side of the popup box, like the margin is set off screen, if that makes sense.
I'm playing the game windowed + maximized.
By "activated it in the mods menu" do you mean checked it, and clicked apply? Which results in the game exiting.
To get logs, run the game from a shell prompt. it outputs to the shell all the messages. If there's no Random Portrait button, then the mod did not apply correctly. You might need to extract a fresh copy of the game, and apply the mod again, thus time running it from the shell, to see what errors might happen. Some errors are normal though, so if anything can be worth while to run the game, and exit it once, just to see what normally happens. Then run it again, apply the mod, and see if any different errors appear. I don't know if mods work on Mac as I haven't read of anyone trying and my only mac is a work laptop.
The game has it's own random portrait code, but it *only* uses race, so that's likely what you saw get applied.
Short answer: Mods can't work on OSX at all currently, and probably for the foreseeable future.
The errors you've posted to me suggested it is not working at all on your machine, and maybe Mac's in general. Basically, the mod engine is trying to build a backup folder, and failing. That's the first step to applying a mod, it makes a backup copy of all the files, then loads the backup copy of files, and applies the mod. If it can't make the backup, it'll never actually apply a mod.
I just downloaded the OSX build of the game, and looking in that zip, I don't see how the mod engine could work at all on OSX. The mod engine expects to find a "files" folder that contains all the .gd files, but the osx package of the game doesn't have that, all the resources seem to be packaged up in a pck file. So mod engine, tries to find script files in the files folder, and it doesn't exist, so it errors a bunch trying to backup things. then when trying to apply the mod, it can't find the backup folder so errors some more and basically does nothing.
I'm not sure if there's some way to have the game not use a pck file on OSX or not? If it needs to be built differently or could be manually achieved? The mod engine could also potentially be able to detect things are in a pck file and instead iterate on the files inside there and be made to work, however without a mac to actually test this on, it'd be a bit difficult to achieve.
It works just fine for me, check if its the modloader that got broken from enabling/disabling mods. Just do a fresh install of 5.21b, making sure you erase backups folder and try again, if the problem persists then it may be a problem with your randomportraits download, because on my side it works as intended. Same windows 10 64 bit, strive 5.21b.
# Filter on Gender
filteringPortraits = []
for p in validPortraits:
if p.genders.has(person.sex):
filteringPortraits.append(p) #Add portrait that has required sex
if portraitSettings.debug: print('Filtered on gender %s, resulted in %d portraits.' % [person.sex, filteringPortraits.size()])
if !filteringPortraits.empty():
if (filteringPortraits.size() < portraitSettings.minMatch):
return
validPortraits.clear()
validPortraits = filteringPortraits
It's quite a small change in randomportraits.gd. (If you get some indent compile errors, as I did, use spaces instead of indents).
There is no option in my mod to only check for race, that's maybe one of the game's options for its own simplistic random portrait code, which this mod completely replaces.
I think you could achieve this by changing minMatch to -1 ? This would affect more than just the gender filtering though. Right now, for race or gender, if the matches are below minMatch, it aborts. If it's not, but the result is empty, then it ignores that filter. so if these conditions are met:
Then instead of aborting like it would with a minMatch, it will discard the filtering on gender. It'll filter on it, see that the result is empty, and continue with the prior list. It'll however apply this to Races too, so if it filters on race and gets 0, it'll revert to using all portraits, then trying to filter on gender, if that's also 0, it'll continue with all portraits (or a set of portraits for a race if you had one).
I think a more ideal way to handle this would be to have settings for whether it aborts or ignores the filter when below minMatch for race, gender, and age.
I haven't been playing the game as much lately and thus not too active on the mod. Not sure if/when that might change.
portrait.gd
Line 21, you'd want to change like this I think, haven't tested.
filterRegex.compile('(?!dark ?)elf')
This will make sure it doesn't match just "elf" on files named "Dark Elf"
then later on you'd want to change line 26 like this, so it'll support both with and without spaces.
if file.findn(race.replace(' ','')) >= 0 || file.findn(race >= 0:
Entire file, and again i didn't test these but should roughly work.
Here's a quick guide, it may cover stuff you already know.
This mod does not include any portraits, you need to download them separately and put them in the AppData's "portraits" or "bodies" folders.
This mod should be extracted from the zip archive into the AppData's "mods" folder. Be sure that the path fits the form of "Strive/mods/<modname>/info.txt", as it will not install correctly if there are more or less folders in the path. (If the mod is in the folder named "randomportraits1.0", then it is probably wrong.)
Once in place, mods are applied to the game through the "Mods" panel located in the game's main screen. Select the mods to be applied, then press "Apply". The game will attempt to apply the mods, but will not inform you of any problems that occurred. Thus, mods need to be verified manually. This mod can generally be verified by loading a progress, select a slave, open the Customization tab, and look for the "Random Portrait" button. If present, then the mod has successfully been applied, though it may still conflict with other mods.
"info.txt" is a file located inside mods that provides an explanation of the mod. If you have "randomportraits1.0", then you have too many folders. Look inside that folder, you will find the folder "randomportraits", and inside that folder you will find "info.txt". You need to remove the contents of "randomportraits1.0" and put them into the AppData's "mods" folder. That way AppData will have a path containing "Strive/mods/randomportraits/info.txt".
Okay, this is good information; however, based on that the mod was most likely not installed correctly, as the presence of the random portrait button is the simplest sign that the mod has been installed. The fact that you can select portraits manually means that there is probably no issues on that side.
You have probably seen the install instructions I gave a few posts above this, please be sure that you have followed them carefully. I'll try to give a detailed list of things to verify.
On windows, there should be a file path "C:\Users\USERNAME\AppData\Roaming\Strive\mods\randomportraits\info.txt". If correct, the contents of that file will display on the right side of the panel when you hover the mouse over the mod name in the mod panel.
Press the "Active Mods" button on the mod panel. Near the top left corner of the mod panel, the text "Active Mod List" should appear as part of a transparent popup, with "randomportraits" underneath. (The visibility of this popup can be fixed by my bugfix patch on the Strive Discord, but it will not effect whether the mod works) If the mod is not listed, then try applying the mod.
In the folder containing game files, find and open the game file "Strive\files\scripts\mainmenu.gd" with any decent text editor. Find the line "globals.constructor.randomportrait(startSlave)", it should be just below the line "func _on_slaveconfirm_pressed():". If that line is not present, then the mod system did not add the mod to the game files. You may need to move the Strive game files to a new location or change the permissions of the folder to allow the game to change it's own files. A user once had an issue with permissions due to the game being located in the standard "Program Files" folder.
